On Fri, Dec 4, 2020 at 5:39 PM Joe Orton <[email protected]> wrote: > > On Sun, Nov 22, 2020 at 01:06:11AM -0000, [email protected] wrote: > > Author: ylavic > > Date: Sun Nov 22 01:06:11 2020 > > New Revision: 1883708 > > > > URL: http://svn.apache.org/viewvc?rev=1883708&view=rev > > Log: > > core: reset ap_runtime_dir to NULL after AP_SQ_MS_DESTROY_CONFIG. > > > > ap_runtime_dir_relative() might reuse ap_runtime_dir from previously cleared > > pconf otherwise. > > There was the same bug with state_dir handling at one point too, can we > unify this to maybe avoid future similar mistakes? Is this sufficient > for whatever problem you saw as well?
Yes, good idea, ASan didn't detect other "reload" issues than ap_runtime_dir so we should be good (for now :). I'll try running the tests suite with --enable-mods-static=reallyall (i.e. no DSOs unload/reload) so that there is no static re-initialization in modules. This could help detect more issues like this.. Regards; Yann.
