On 3/3/21 10:56 AM, Yann Ylavic wrote:
> On Wed, Mar 3, 2021 at 9:05 AM Ruediger Pluem <rpl...@apache.org> wrote:
>>
>>
>> I think the change to core_filters.c is unrelated.
>
> The changes are unrelated to each other yes, but the proposal was to
> fix r1885239 and r1885573 in one go (both from the mod_proxy/core
> series which made it to 2.4.x a few time ago):
>
> - *) mod_proxy_http, core: Fixes against 2.4.x's r1885239 and r1885573, the
> - former for declining CONNECT requests in mod_proxy_http, the latter for
> - ignored poll timeouts and errors in the core output filter.
> - trunk patch: http://svn.apache.org/r1886141
> - http://svn.apache.org/r1886151
> - 2.4.x patch:
> http://home.apache.org/~ylavic/patches/follow_up_to_r1885239_and_r1885573-v2.patch
> - (includes follow up to r1885573 which is 2.4.x only)
> - +1: ylavic, covener, icing
>
> These fixes come from your reviews (excellent as always! :) plus this
> core_filers.c change was needed in 2.4.x only (code is now aligned
> with trunk's), so I thought it was simpler to group them in a single
> proposal as "2.4.x fixup for a series applied in this cycle and before
> it's released"..
All good. I guess it would have lowered my confusion if there would have been a
pointer in STATUS that this backports
stuff needed for 2.4.x from r1836237 as well.
Regards
Rüdiger
