On Thu, Aug 19, 2021 at 03:28:44PM +0200, Yann Ylavic wrote: > The only filters that care about write completion for now are > ap_core_output_filter() and ssl_io_filter_output(), which try to fill > in the pipe as much as possible, using > ap_filter_reinstate_brigade(&flush_upto) to determine whether they > should flush (blocking) or setaside their remaining data. > > So ap_filter_reinstate_brigade() is made to not treat WC as FLUSH > buckets and keep the above filters working as before (and correctly > w.r.t WC bucket semantics). I first thought adding a new > ap_filter_rec->proto_flags like AP_FILTER_PROTO_WC_READY to do this > only for filter registered with this flag, and then register > ap_core_output_filter() and ssl_io_filter_output() accordingly, but > since they are the only users of ap_filter_reinstate_brigade() with > flush_upto != NULL I kept it simple for now.. > > WDYT?
+1 Very nice, I like it, thanks Yann. Regards, Joe
