On Tue, Jan 25, 2022 at 8:18 PM Graham Leggett <minf...@sharp.fm> wrote: > > On 25 Jan 2022, at 13:57, Stefan Eissing <ste...@eissing.org> wrote: > > > Failure in https://app.travis-ci.com/github/apache/httpd/jobs/556778281 > > indicates that the SSL handshake timeout no longer is working. > > Also logs mpm:error several times. > > > > The test opens a socket and sends one byte, then waits for > > the connection to close with the configured timeout. > > Alas there is no SSL handshake timeout, but rather a timeout implemented by > mod_reqtimeout, which in turn steps out of the way as soon as the connection > is non blocking. Problem is on this line: > > https://github.com/apache/httpd/blob/trunk/modules/filters/mod_reqtimeout.c#L220 > > mod_reqtimeout needs to be taught how to not-block.
What do you mean? reqtimeout_filter() will pass nonblocking calls (not making them block!) though it will still check for each read (including nonblocking ones) that the current stage's timeout is not exceeded (handshake, header, body). So if mod_reqtimeout triggers it's rather that the handshake takes too long to complete? Regards; Yann.