On 6/1/22 11:10 AM, Yann Ylavic wrote:
> On Wed, Jun 1, 2022 at 8:29 AM Ruediger Pluem <rpl...@apache.org> wrote:
>>
>> On 5/31/22 5:06 PM, yla...@apache.org wrote:
>>> }
>>> + ap_h1_append_header(header_brigade, r->pool, "Host", host);
>>> + apr_table_unset(r->headers_in, "Host");
>>
>> This is nothing introduced by this change but something I noticed. If the
>> fixup hook adds back a Host header,
>> we would sent two Host headers to the backend.
>
> I thought about it, and also that proxy_run_fixups doesn't know about
> the forwarded Host header.
> I hesitated between simply ignoring any Host set by proxy_run_fixups
> (i.e. move the apr_table_unset("Host") after that) or take it into
> account.
> The latter would be something like this:
+1. This is more safe.
Regards
Rüdiger
