2.4.x ready to reroll On Sat, Jun 4, 2022 at 7:36 AM Eric Covener <cove...@gmail.com> wrote: > > On Sat, Jun 4, 2022 at 7:11 AM Stefan Eissing <ste...@eissing.org> wrote: > > > > How is the definition in your include/apr.h for APR_TCP_NOPUSH_FLAG? On my > > macOS it is: > > > > #define APR_TCP_NOPUSH_FLAG TCP_NOPUSH > > > > It maybe that the added lines > > > > #if APR_TCP_NOPUSH_FLAG && !defined(__APPLE__) > > > > needs a check for Windows too? > > On my fork which is the only thing I can easily rebuild on Windows: > > C:\cygwin64\home\ihstest\SRC\2.4.x\server\core_filters.c(87) : fatal > error C1017: invalid integer constant expression^M > > srclib/apr/cmakebuild/apr.h:#define APR_TCP_NOPUSH_FLAG > > I think whatever APR is missing 892162 from apr-trunk which defines this to 0. > > We should put some kind of hack into httpd I guess. I will do some > trial and error in my sandbox. > > -- > Eric Covener > cove...@gmail.com
-- Eric Covener cove...@gmail.com
