On Mon, Jun 20, 2022 at 1:23 PM Stefan Eissing <ste...@eissing.org> wrote:
>
> > Am 20.06.2022 um 13:08 schrieb Yann Ylavic <ylavic....@gmail.com>:
> >
> > On Fri, Jun 17, 2022 at 11:24 AM <ic...@apache.org> wrote:
> >>
> >> --- httpd/httpd/trunk/modules/http2/h2_workers.h (original)
> >> +++ httpd/httpd/trunk/modules/http2/h2_workers.h Fri Jun 17 09:24:57 2022
> >> @@ -28,59 +28,94 @@ struct h2_mplx;
> >> struct h2_request;
> >> struct h2_fifo;
> >>
> >> -struct h2_slot;
> >> -
> >> typedef struct h2_workers h2_workers;
> >>
> >> -struct h2_workers {
> >
> > Since h2_workers is now opaque, some debug code (-DAPR_POOL_DEBUG) now
> > raises:
> >
> > h2_mplx.c: In function ‘h2_mplx_c1_process’:
> > h2_mplx.c:717:46: error: dereferencing pointer to incomplete type
> > ‘struct h2_workers’
> > mem_w = apr_pool_num_bytes(m->workers->pool, 1);
> >
> > Not sure how to fix it though.
>
> I take that number out from the logging. If we want to debug the workers
> pool, we pbly should add something there which can then also use the lock for
> safety.
Fine by me, thanks!
Regards;
Yann.
