Thanks for your feedback, Christophe! We have addressed all these different issues in our repo: - All logging is now properly route to `ap_log_error()`, `ap_log_perror()` and `ap_log_rerror()`. - Also now using APLOG_MARK, and all errors marked as APLOG_ERR. - Removed unused code in create_dir_config(). - Apache-2.0 extended license headers. - Only C89 comments (/* */), double new lines removed. - Other minor tweaks.
An updated patch is attached. It might also be interesting to submit a PR to the mirror repo at GitHub to ease the review, but I think I'd need proper permissions. Just let me know what you prefer. Our goal is still to donate the code to the ASF and help to maintain it. Cheers, Jesús El 9/12/22, 19:39, "Christophe JAILLET" <christophe.jail...@wanadoo.fr <mailto:christophe.jail...@wanadoo.fr>> escribió: !! External Email Le 28/11/2022 à 19:17, Jesús González a écrit : > Hi everyone, > > Following up on our email about contributing mod_wasm, we have continued > to make progress on our side and just released mod_wasm v0.10.0. > Hi, just a few nits to clean code and help reviews: - No need to send html files, it will be generated by the framework - I don't see the need for trace_nocontext(). Also have a look at APLOG_MARK and its usages. - APLOG_NOTICE looks too high for trace logging. APLOG_DEBUG? - At the end of create_dir_config(), 'note' and the corresponding apr_psprintf() are useless or a debugging logging call is missing - Please use only C89 comments (/* */) - try to configure with --enable-maintainer-mode - some double new lines could be saved CJ
mod_wasm_v0.10.1.diff
Description: mod_wasm_v0.10.1.diff
