On Mon, Mar 13, 2023 at 12:31 PM Yann Ylavic <ylavic....@gmail.com> wrote:
>
> On Mon, Mar 13, 2023 at 5:25 PM Eric Covener <cove...@gmail.com> wrote:
> >
> > On Mon, Mar 13, 2023 at 12:05 PM Yann Ylavic <ylavic....@gmail.com> wrote:
> > >
> > > I could get where you want to with the attached patch (before you
> > > disabled the test in r1908350).
> > > It makes so that anything BNEG'ed overrides BCTLS, which can be useful
> > > to let space through while still encoding controls.
> > > I had to fix the local_bctls_nospace RewriteRule to not encode '/'
> > > (not expected in the result) and add a missing '/' in the result too.
> >
> >
> > +    RewriteRule ^/modules/rewrite/escaping/local_bctls_nospace/(.*)
> > /?$1 "[B= /,BNEG,BCTLS]"
> > +    [ "/modules/rewrite/escaping/local_bctls_nospace/foo/bar/%20baz/%0d"
> >  =>  "foo/bar/ baz/%0d"],       # CTLS but allow space
> >
> > I'm not sure I understand this, / isn't a CTL so why do we need to
> > exclude it with B+BNEG to have it passed through in the test?
>
> With BNEG everything not in B= is encoded, so "[B= ?,BNEG]"
> (regardless of BCTLS) will encode '/'.

Ah, I see. I thought/hoped it would become relative to CTLS. Maybe
best to keep it simple.

-- 
Eric Covener
cove...@gmail.com

Reply via email to