Re: svn commit: r1908684 - in /httpd/httpd/trunk: docs/log-message-tags/next-number modules/cache/mod_cache_disk.c

[giovanni]

On 3/28/23 12:49, Joe Orton wrote:

On Fri, Mar 24, 2023 at 08:50:19AM -0000, gbec...@apache.org wrote:

Author: gbechis
Date: Fri Mar 24 08:50:19 2023
New Revision: 1908684

URL: http://svn.apache.org/viewvc?rev=1908684&view=rev
Log:
add error message when storing data to temp file fails.
Github: closes #182

Hi Giovanni, thanks for taking care of the PRs, that is really great to
see.

FYI when you are committing code written by someone else it is customary
to include "Submitted by:" in the commit message to give them due
credit, like:

Submitted by: Name of Person <person example.com>

will do

There are guidelines here:
https://httpd.apache.org/dev/guidelines.html#changes-file-and-subversion-logs

If you use Ruediger's apply_trunk_pr.sh script from here:
https://svn.apache.org/repos/asf/httpd/dev-tools/github/
it will do this automatically for you for a PR, including extracting the
full name properly from the github metadata (which is really neat).

thanks, I was not aware of this script.
 Giovanni

OpenPGP_signature
Description: OpenPGP digital signature