On 11/2/23 1:47 PM, Yann Ylavic wrote:
> On Sat, Sep 30, 2023 at 7:19 PM Ruediger Pluem <rpl...@apache.org> wrote:
>>
>> On 9/21/23 3:15 PM, yla...@apache.org wrote:
>>
>>> --- httpd/httpd/trunk/modules/proxy/proxy_util.c (original)
>>> +++ httpd/httpd/trunk/modules/proxy/proxy_util.c Thu Sep 21 13:15:35 2023
>>
>>> @@ -2683,56 +3116,83 @@ ap_proxy_determine_connection(apr_pool_t
>>> +
>>> + if (proxyname) {
>>> + forward_info *forward;
>>> +
>>> + hostname = proxyname;
>>> + hostport = proxyport;
>>> +
>>> + /* Reset forward info if they changed */
>>> + if (conn->is_ssl
>>> + && (!(forward = conn->forward)
>>> + || forward->target_port != uri->port
>>> + || ap_cstr_casecmp(forward->target_host,
>>> + uri->hostname) != 0)) {
>>> + apr_pool_t *fwd_pool = conn->pool;
>>> + if (worker->s->is_address_reusable) {
>>> + if (conn->fwd_pool) {
>>> + apr_pool_clear(conn->fwd_pool);
>>> + }
>>> + else {
>>> + apr_pool_create(&conn->fwd_pool, conn->pool);
>>> + }
>>
>>
>> Don't we need to
>>
>> fwd_pool = conn->fwd_pool
>>
>> ??
>
> Sorry I missed your message somehow.
> Yes you are right of course!
>
> And with a fresh look at this new forward_info reuse mechanism I think
> we also need to check whether the ->proxy_auth has changed too.
> Something like the attached (which also includes your proposed change above)?
Looks good.
Regards
Rüdiger
