On Wed, Jun 26, 2024 at 1:17 AM Eric Covener <cove...@gmail.com> wrote: > > On Tue, Jun 25, 2024 at 7:03 PM Yann Ylavic <ylavic....@gmail.com> wrote: > > > > On Wed, Jun 26, 2024 at 12:37 AM Eric Covener <cove...@gmail.com> wrote: > > > > > > > The attached might work, currently testing but sending early if you > > > > want to try too. > > > > > > looks like proxy: is stripped off after the new call and needs to be > > > added back in? > > > > Yeah, the new call to ap_proxy_fixup_uds_filename() should not take > > &r->filename as argument. > > Fixed in this new version. > > +1 with basic "fakefpm" and real fpm hello-world. Please commit to > trunk when practical.
Done in r1918626. Looks good in my manual testing too, there will be two calls to ap_proxy_fixup_uds_filename() when proxying from r->handler, first in proxy_handler() and second in ap_proxy_pre_request(), but since the first will strip the UDS already the other call is a noop. We can eventually rework this after the release. > > If we can get another review for 2.4.x I can add it and roll an rc so > it can be more easily picked up for testing. +1 Regards; Yann.
