On 11/20/24 3:44 PM, jean-frederic clere wrote:
> On 11/20/24 3:03 PM, Ruediger Pluem wrote:
>>
>>
>> On 11/20/24 2:11 PM, jfcl...@apache.org wrote:
>>> Author: jfclere
>>> Date: Wed Nov 20 13:11:11 2024
>>> New Revision: 1921973
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1921973&view=rev
>>> Log:
>>> Merge PR#419: make sure the right method is displayed.
>>>
>>> Modified:
>>> httpd/httpd/trunk/modules/http/http_protocol.c
>>> httpd/httpd/trunk/modules/http/http_request.c
>>>
>>
>>>
>>> Modified: httpd/httpd/trunk/modules/http/http_request.c
>>> URL:
>>> http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http/http_request.c?rev=1921973&r1=1921972&r2=1921973&view=diff
>>> ==============================================================================
>>> --- httpd/httpd/trunk/modules/http/http_request.c (original)
>>> +++ httpd/httpd/trunk/modules/http/http_request.c Wed Nov 20 13:11:11 2024
>>> @@ -127,6 +127,7 @@ static void ap_die_r(int type, request_r
>>> */
>>> update_r_in_filters(r_1st_err->proto_output_filters, r,
>>> r_1st_err);
>>> update_r_in_filters(r_1st_err->input_filters, r, r_1st_err);
>>> + recursive_error = type;
>>
>> How is this one related to "make sure the right method is displayed." ?
>
> Basically that is to have:
> +++
> jfclere@fedora:~/APACHE$ curl -isX TRACE localhost:8000
> HTTP/1.1 405 Method Not Allowed
> Date: Wed, 20 Nov 2024 14:41:17 GMT
> Server: Apache/2.5.1-dev (Unix) OpenSSL/3.2.2
> Allow:
> Content-Length: 381
> Content-Type: text/html; charset=iso-8859-1
>
> <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN"
> "http://www.w3.org/TR/html4/strict.dtd";>
> <html><head>
> <title>405 Method Not Allowed</title>
> </head><body>
> <h1>Method Not Allowed</h1>
> <p>The requested method TRACE is not allowed for this URL.</p>
> <p>Additionally, a 404 Not Found
> error was encountered while trying to use an ErrorDocument to handle the
> request.</p>
> </body></html>
> +++
>
> Note the 404 here...
>
> Otherwise the html text will say:
>
> +++
> jfclere@fedora:~/APACHE$ curl -isX TRACE localhost:8000
> HTTP/1.1 405 Method Not Allowed
> Date: Wed, 20 Nov 2024 14:40:13 GMT
> Server: Apache/2.5.1-dev (Unix) OpenSSL/3.2.2
> Allow:
> Content-Length: 390
> Content-Type: text/html; charset=iso-8859-1
>
> <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN"
> "http://www.w3.org/TR/html4/strict.dtd";>
> <html><head>
> <title>405 Method Not Allowed</title>
> </head><body>
> <h1>Method Not Allowed</h1>
> <p>The requested method TRACE is not allowed for this URL.</p>
> <p>Additionally, a 405 Method Not Allowed
> error was encountered while trying to use an ErrorDocument to handle the
> request.</p>
> </body></html>
> +++
>
> Do we want to fix that too?
Good point and catch. Yes I think we want to fix this.
Regards
Rüdiger
