Hi Joe and all,

Am 16.09.26 um 16:36 schrieb [email protected]:
Author: jorton
Date: Wed Sep 16 14:36:32 2026
New Revision: 1938292

Log:
* modules/metadata/mod_remoteip.c (remoteip_modify_request): Trim
   trailing spaces using a one-past-the-end pointer, so the pointer is
   never decremented to before the start of the buffer when the
   token is empty.  Test for an empty token with equality instead.

* test/modules/proxy/test_03_response.py (TestProxyResponse): Add
   127.0.0.1 as a trusted RemoteIP proxy.
   (test_proxy_03_004): Move after test_proxy_03_002.
   (test_proxy_03_005): New test: an X-Forwarded-For header ending in
   an empty token must still get a 200 response.

Submitted by: Robert McConnell <robert mcc0nnell.org>
GitHub: closes #756
These tests seem to succeed when backported to 2.4.x. Not sure, whether they only make sense to check the trunk-only changes in mod_remoteip, or whether it would be useful if I merged just these tests to 2.4.x? Or in this case I could also propose the complete change for backport?

Thanks and regards,

Rainer

Reply via email to