bvaradar commented on a change in pull request #603: [HUDI-63] Removed unused
BucketedIndex code
URL: https://github.com/apache/incubator-hudi/pull/603#discussion_r266092419
##########
File path:
hoodie-common/src/main/java/com/uber/hoodie/common/table/log/HoodieLogFormatVersion.java
##########
@@ -80,18 +80,15 @@ public boolean hasHeader() {
@Override
public boolean hasFooter() {
- switch (super.getVersion()) {
- case DEFAULT_VERSION:
- return false;
- case 1:
- return true;
- default:
- return false;
- }
+ return getResultByVersion();
}
@Override
public boolean hasLogBlockLength() {
+ return getResultByVersion();
+ }
+
+ private boolean getResultByVersion() {
Review comment:
Good cleanup. Can you rename this to hasLogFooterAndBlockLength() ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
