Got a few reviews on the PR. So going ahead and merging. Please feel free to still leave comments on the PR, if you still have em.
On Mon, Aug 5, 2019 at 9:10 AM Vinoth Chandar <[email protected]> wrote: > Gentle reminder to review this PR! :) Have a great week! > > On Fri, Aug 2, 2019 at 5:29 AM Vinoth Chandar <[email protected]> wrote: > >> hello all, >> >> Put up a draft here https://github.com/apache/incubator-hudi/pull/823 >> Please review >> >> /thanks/vinoth >> >> On Tue, Jul 30, 2019 at 9:53 PM vino yang <[email protected]> wrote: >> >>> +1 >>> >>> IMO, the guidelines of both Flink and Beam are good. We can learn all the >>> advantages of them. >>> >>> Best, >>> Vino >>> >>> Thomas Weise <[email protected]> 于2019年7月31日周三 上午4:52写道： >>> >>> > Hi Vinoth, >>> > >>> > Take a look at this as well: >>> > https://beam.apache.org/contribute/become-a-committer/ >>> > >>> > It is not just the criteria, but more so the path to get there. And >>> what we >>> > can do to encourage and recognize contributions. >>> > >>> > Thomas >>> > >>> > >>> > On Tue, Jul 30, 2019 at 11:30 AM Suneel Marthi <[email protected]> >>> wrote: >>> > >>> > > Please go ahead - we can review the PR. >>> > > >>> > > On Tue, Jul 30, 2019 at 1:51 PM Vinoth Chandar <[email protected]> >>> > wrote: >>> > > >>> > > > +1 looks good. >>> > > > >>> > > > If no one objects (lazy consensus), I will draft a PR based on this >>> > (and >>> > > > may be 1 more project) and share here? >>> > > > >>> > > > On Mon, Jul 29, 2019 at 10:56 AM Suneel Marthi <[email protected] >>> > >>> > > wrote: >>> > > > >>> > > > > A good start here ---> >>> > > > > https://flink.apache.org/contributing/how-to-contribute.html >>> > > > > >>> > > > > On Mon, Jul 29, 2019 at 1:54 PM Vinoth Chandar < >>> [email protected]> >>> > > > wrote: >>> > > > > >>> > > > > > Hello mentors, >>> > > > > > >>> > > > > > I realized that we have not replaced our committership criteria >>> > with >>> > > > new >>> > > > > > ones, post the move to ASF. Would like to get that ball >>> rolling. >>> > > > > > >>> > > > > > This seems like something we vote on? what do you think? >>> > > > > > >>> > > > > > /thanks/vinoth >>> > > > > > >>> > > > > >>> > > > >>> > > >>> > >>> >>
