+1 (non-binding) on other aspects.
- verified checksums and signatures [SUCCESS]
- built from source release (mvn clean install -DskipTests) [SUCCESS]
- ran local docker tests [SUCCESS]
- ran some IDE tests [SUCCESS]

Thanks,
Sudha


On Sat, Sep 14, 2019 at 6:46 PM Vinoth Chandar <[email protected]> wrote:

> -1 (binding)
>
> - Checksums & Signatures verify
> - Built the branch & tests pass
> - My own test jobs seem to work
>  - Checked pom for version
>  - NOTICE and LICENSE I think were updated right before RC was cut. Should
> be good to go
>  - Source files all have ASF license . Tested rat plugin fails build if
> java/scala files don't have license.
>
> But, checked other vote threads on general@incubator to understand any
> gaps
> [1] and have some concerns
> Most discussions mention DISCLAIMER. is this the disclaimer we have on
> site? or a separate file like this
>
> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_incubator-2Dheron_blob_master_DISCLAIMER-3F&d=DwIFaQ&c=r2dcLCtU9q6n0vrtnDw9vg&r=oyPDRKU5b-LuEWWyf8gacx4mFFydIGdyS50OKdxizX0&m=6OACEXf4lzybehn_i2Q0YBCpsZTN98wE4ii347BUKDU&s=luHVLuRJrqND1UCrOiTq176TCoQJ9SIfZGNRPyGRAc4&e=
> If
> latter, I think we need to add it.
>
> Release manager, kindly take note if we need to do anything to handle these
> before the general vote
>
> P.S: Found this to be a great resource for verifying the package
>
> https://urldefense.proofpoint.com/v2/url?u=https-3A__www.apache.org_info_verification.html&d=DwIFaQ&c=r2dcLCtU9q6n0vrtnDw9vg&r=oyPDRKU5b-LuEWWyf8gacx4mFFydIGdyS50OKdxizX0&m=6OACEXf4lzybehn_i2Q0YBCpsZTN98wE4ii347BUKDU&s=VE-T7bsasyA-9IBP5mztzksc5FHjQTHK9sEySUco8wA&e=
>
> On Sat, Sep 14, 2019 at 9:17 AM Prasanna Rajaperumal <[email protected]>
> wrote:
>
> > +1 (binding)
> >
> > Great job getting the RC out!
> >
> > - verified checksums
> > - verified signatures
> > - Built the branch and my tests pass
> >
> >
> > On 2019/09/14 13:19:25, leesf <[email protected]> wrote:
> > > +1 (non-binding)
> > >
> > > - verified checksums and signatures - OK
> > > - checked that all pom.xml files point to the same
> > > version(0.5.0-incubating-rc1) - OK
> > > - built from source(mvn clean install -DskipTests) - OK
> > > - ran some tests in IDE - OK
> > >
> > > Best,
> > > Leesf
> > >
> > > [email protected] <[email protected]> 于2019年9月14日周六 上午6:32写道:
> > >
> > > > Hi everyone, We have prepared the first apache release candidate for
> > > > Apache Hudi (incubating). The version is : 0.5.0-incubating-rc1.
> Please
> > > > review and vote on the release candidate #1 for the version 0.5.0, as
> > > > follows:[ ] +1, Approve the release
> > > > [ ] -1, Do not approve the release (please provide specific comments)
> > > > The complete staging area is available for your review, which
> includes:
> > > >    - JIRA release notes [1]
> > > >    - The official Apache source release and binary convenience
> > releases to
> > > > be deployed to
> https://urldefense.proofpoint.com/v2/url?u=http-3A__dist.apache.org&d=DwIFaQ&c=r2dcLCtU9q6n0vrtnDw9vg&r=oyPDRKU5b-LuEWWyf8gacx4mFFydIGdyS50OKdxizX0&m=6OACEXf4lzybehn_i2Q0YBCpsZTN98wE4ii347BUKDU&s=ecQHabJSqEgYr80kZcxsVRV6TD2cI1GC08OdVtbIHyo&e=
> [2], which are signed with the key with
> > > > fingerprint AF9BAF79D311A3D3288E583F24A499037262AAA4  [3],
> > > >
> > > >    - all artifacts to be deployed to the Maven Central Repository [4]
> > > >
> > > >    - source code tag "release-0.5.0-incubating-rc1" [5]
> > > >
> > > > The vote will be open for at least 72 hours.
> > > > Please cast your votes before *Sep. 18th 2019, 23:00 UTC*.
> > > >
> > > > It is adopted by majority approval, with at least 3 PMC affirmative
> > > > votes.
> > > >    -
> > > >
> >
> https://urldefense.proofpoint.com/v2/url?u=https-3A__jira.apache.org_jira_secure_ReleaseNote.jspa-3FprojectId-3D12322822-26version-3D12346087&d=DwIFaQ&c=r2dcLCtU9q6n0vrtnDw9vg&r=oyPDRKU5b-LuEWWyf8gacx4mFFydIGdyS50OKdxizX0&m=6OACEXf4lzybehn_i2Q0YBCpsZTN98wE4ii347BUKDU&s=k_heTdP8MHhsACoOqXUjIT3hmcfexCozZjPZM323SFk&e=
> > > >    -
> > > >
> https://urldefense.proofpoint.com/v2/url?u=https-3A__dist.apache.org_repos_dist_dev_hudi_hudi-2D0.5.0-2Dincubating-2Drc1_&d=DwIFaQ&c=r2dcLCtU9q6n0vrtnDw9vg&r=oyPDRKU5b-LuEWWyf8gacx4mFFydIGdyS50OKdxizX0&m=6OACEXf4lzybehn_i2Q0YBCpsZTN98wE4ii347BUKDU&s=33aQTSY9N5Nj6Vh3jU8_HPID8gP68ZrOaGpJinitle0&e=
> > > >    -
> https://urldefense.proofpoint.com/v2/url?u=https-3A__dist.apache.org_repos_dist_release_hudi_KEYS&d=DwIFaQ&c=r2dcLCtU9q6n0vrtnDw9vg&r=oyPDRKU5b-LuEWWyf8gacx4mFFydIGdyS50OKdxizX0&m=6OACEXf4lzybehn_i2Q0YBCpsZTN98wE4ii347BUKDU&s=UgOsGoDP21Q5aja4vTcERgNpAtdE-AAozGDb934G4Vc&e=
> > > >    -
> > > >
> https://urldefense.proofpoint.com/v2/url?u=https-3A__repository.apache.org_content_repositories_orgapachehudi-2D1001_&d=DwIFaQ&c=r2dcLCtU9q6n0vrtnDw9vg&r=oyPDRKU5b-LuEWWyf8gacx4mFFydIGdyS50OKdxizX0&m=6OACEXf4lzybehn_i2Q0YBCpsZTN98wE4ii347BUKDU&s=PlxvoaiMFOpmQjoJUk8XE8xnZrb1BQP50oXmUIxnnXI&e=
> > > >    -
> > > >
> >
> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_incubator-2Dhudi_tree_release-2D0.5.0-2Dincubating-2Drc1&d=DwIFaQ&c=r2dcLCtU9q6n0vrtnDw9vg&r=oyPDRKU5b-LuEWWyf8gacx4mFFydIGdyS50OKdxizX0&m=6OACEXf4lzybehn_i2Q0YBCpsZTN98wE4ii347BUKDU&s=CRUTPIqEwKM52K_BTV53mUmVXPWJngzIu_u8MI_1gEo&e=
> > > >
> > > >
> > > >
> > > > P.S. : As this is a first time where Hudi community will be
> performing
> > > > release voting, you can look at
> > > >
> >
> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.apache.org_thread.html_75e40ed5a6e0c3174728a0bcfe86cbcd99ae4778ebe94b839f0674cd-40-253Cdev.flink.apache.org-253E&d=DwIFaQ&c=r2dcLCtU9q6n0vrtnDw9vg&r=oyPDRKU5b-LuEWWyf8gacx4mFFydIGdyS50OKdxizX0&m=6OACEXf4lzybehn_i2Q0YBCpsZTN98wE4ii347BUKDU&s=Fq21pMxCDwfUZJX15vsIORcRSXTOh9H9BQmdmeTUtAg&e=
> > for
> > > > some understanding of validations community does to cast their
> > > > votes.Thanks,Balaji.V
> > > >
> > >
> >
>

Reply via email to