Thanks Thomas. We will follow the best-practice around rebasing between 
release candidate generation.
     On Thursday, October 17, 2019, 9:10:55 AM PDT, Thomas Weise 
<[email protected]> wrote:  
 
 +1 (binding)

I was surprised about the large diff compared to the previous release
though. Looking at
https://github.com/apache/incubator-hudi/commits/release-0.5.0-incubating-rc6
it
appears it includes a rebase to master? I think the difference between RCs
should be limited to the issues raised to reduce the risk of new problems
popping up.

Thanks,
Thomas


On Wed, Oct 16, 2019 at 10:10 PM nishith agarwal <[email protected]>
wrote:

> +1 (binding)
>
> Thanks,
> Nishth
>
> On Wed, Oct 16, 2019 at 8:00 PM vino yang <[email protected]> wrote:
>
> > +1 (non-binding)
> >
> > - checked release note
> >
> > Best,
> > Vino
> >
> > leesf <[email protected]> 于2019年10月17日周四 上午7:07写道:
> >
> > > +1 (non-binding)
> > >
> > > Best,
> > > Leesf
> > >
> >
>  

Reply via email to