Thanks. I had some issue w/ local intellij check style configuration. After fixing it, everything is good.
On Thu, Dec 12, 2019 at 12:08 PM lamberken <[email protected]> wrote: > > You are welcome. For detail, you can visit HUDI-363, > https://issues.apache.org/jira/browse/HUDI-363 > > > > best, > lamber-ken > > At 2019-12-13 03:49:12, "Sivabalan" <[email protected]> wrote: > >thanks lamber-ken. Sorry, I wasn't paying close attention to these > changes. > >Don't we make a separate PR (with just the changes pertaining to new check > >style rules across entire repo) whenever a new change is made to check > >style ? I rebased with latest and in order to get my build pass, I have > >already fixed like 20 files and the list keeps growing. > > > > > > > > > > > > > > > >On Thu, Dec 12, 2019 at 10:14 AM lamberken <[email protected]> wrote: > > > >> > >> > >> Hi, @Sivabalan > >> > >> The new ImportOrder rule split import statements into groups and groups > >> are separated by one blank line. > >> These groups are 1) org.apache.hudi 2) third party imports 3) javax > >> 4) java 5) static > >> > >> > >> For example > >> > >> > /--------------------------------------------------------------------------- > >> package org.apache.hudi.metrics; > >> > >> import org.apache.hudi.config.HoodieWriteConfig; > >> import org.apache.hudi.exception.HoodieException; > >> > >> import com.google.common.base.Preconditions; > >> import org.apache.log4j.LogManager; > >> import org.apache.log4j.Logger; > >> > >> import javax.management.remote.JMXConnectorServer; > >> import javax.management.remote.JMXConnectorServerFactory; > >> import javax.management.remote.JMXServiceURL; > >> > >> import java.io.Closeable; > >> import java.lang.management.ManagementFactory; > >> import java.rmi.registry.LocateRegistry; > >> > >> public class JmxMetricsReporter extends MetricsReporter { > >> > >> > >> > /--------------------------------------------------------------------------- > >> > >> > >> best, > >> lamber-ken > >> > >> 在 2019-12-13 01:01:05，"Sivabalan" <[email protected]> 写道： > >> > >> Hi folks, > >> Is there any recent change wrt checkstyle? Usually I run "mvn > package > >> -DskipTests" locally to check for any checkstyle and build errors. And > >> travis CI usually stays in line with that. But recently(probably a week > or > >> 10 days), even though my local maven package command succeeds, travis CI > >> fails specifically wrt import ordering. > >> > >> > >> When I apply reformat code via intellij, usually I choose just "Optimize > >> Imports". But this time around, I also tried choosing "Rearrange > entries", > >> but none helped me in fixing the travis CI failure. > >> > >> > >> Here is my travis CI build: > >> > https://travis-ci.org/apache/incubator-hudi/jobs/624228722?utm_medium=notification&utm_source=github_status > >> > >> > >> - Do others face this issue or it is just me? > >> - Can someone give some pointers on how to go about fixing this? > >> > >> > >> -- > >> > >> Regards, > >> -Sivabalan > > > > > > > >-- > >Regards, > >-Sivabalan > -- Regards, -Sivabalan
