+1 as well .. On Fri, Jan 3, 2020 at 12:09 AM Pratyaksh Sharma <pratyaks...@gmail.com> wrote:
> Hi, > > I will volunteer for the testing and verification part. > > On Fri, Jan 3, 2020 at 1:27 PM vino yang <yanghua1...@gmail.com> wrote: > > > Hi Leesf, > > > > Thanks for this proposal. It makes sense to me. > > If I have time, I will help to verify this work. > > > > so, +1 from my side. > > > > Best, > > Vino > > > > leesf <leesf0...@gmail.com> 于2020年1月3日周五 下午1:55写道： > > > > > Hi all, > > > > > > Since we are going to redo log statements in hudi[1]. And big thanks to > > all > > > for their work to provide PRs actively[2]. > > > > > > However we do need fully verify that the log4j would work well in > > > spark/hive/presto etc before merging into master branch, mainly > > considering > > > the packages conflict. So instead of merging PRs directly into the > master > > > branch, a better solution would be merging these PRs into newly created > > > redo-log branch. After finishing all redo work and fully tested and > > > verified(I will help to verify and any others helpers are highly > > welcome), > > > then we could merge it into master branch. Any thoughts? > > > > > > Best, > > > Leesf > > > > > > [1] https://issues.apache.org/jira/browse/HUDI-233 > > > [2] https://github.com/apache/incubator-hudi/pull/1168 > > > https://github.com/apache/incubator-hudi/pull/1163 > > > https://github.com/apache/incubator-hudi/pull/1161 > > > https://github.com/apache/incubator-hudi/pull/1152 > > > > > >
