+1 (binding)

- checksums and signatures [OK]
- greped for license header check [OK]
- built & ran tests [OK]
- My own test jobs [OK]

On 2020/03/13 05:50:25, Vinoth Chandar <[email protected]> wrote: 
> +1 binding
> 
> 10:05:53 [hudi-0.5.2]$ shasum -a 512 hudi-${RC_VERSION}-${RC_NUM}.src.tgz >
> sha512
> 10:06:01 [hudi-0.5.2]$ diff sha512
> hudi-${RC_VERSION}-${RC_NUM}.src.tgz.sha512.txt | wc -l
>        0
> 10:06:14 [hudi-0.5.2]
> 
> 
> 10:17:11 [hudi-0.5.2]$ gpg --verify
> hudi-${RC_VERSION}-${RC_NUM}.src.tgz.asc.txt
> hudi-${RC_VERSION}-${RC_NUM}.src.tgz
> gpg: Signature made Thu Mar 12 01:24:37 2020 PDT
> gpg:                using RSA key C3A96EC77149571AE89F82764C86684D047DE03C
> gpg: Good signature from "vinoyang (apache gpg) <[email protected]>"
> [unknown]
> gpg: WARNING: This key is not certified with a trusted signature!
> gpg:          There is no indication that the signature belongs to the
> owner.
> Primary key fingerprint: C3A9 6EC7 7149 571A E89F  8276 4C86 684D 047D E03C
> 10:21:43 [hudi-0.5.2]$
> 
> 10:22:04 [hudi-0.5.2]$ tar -zxvf hudi-${RC_VERSION}-${RC_NUM}.src.tgz
> 10:22:22 [hudi-0.5.2]$ # Notice, DISCLAIMER-WIP, LICENSE
> 10:22:24 [hudi-0.5.2]$ ls hudi-${RC_VERSION}-${RC_NUM}/NOTICE
> hudi-0.5.2-incubating-rc1/NOTICE
> 10:22:31 [hudi-0.5.2]$ ls hudi-${RC_VERSION}-${RC_NUM}/DISC*
> hudi-0.5.2-incubating-rc1/DISCLAIMER
> 10:22:36 [hudi-0.5.2]$ ls hudi-${RC_VERSION}-${RC_NUM}/LICENSE
> hudi-0.5.2-incubating-rc1/LICENSE
> 
> 10:23:00 [hudi-0.5.2]$ find hudi-${RC_VERSION}-${RC_NUM}/ -name *.jar | wc
> -l
>        0
> 10:23:09 [hudi-0.5.2]$
> 
> 10:23:09 [hudi-0.5.2]$ grep -LR "Licensed to the Apache Software
> Foundation" hudi-${RC_VERSION}-${RC_NUM}
> hudi-0.5.2-incubating-rc1/docker/demo/data/batch_2.json
> hudi-0.5.2-incubating-rc1/docker/demo/data/batch_1.json
> hudi-0.5.2-incubating-rc1/DISCLAIMER
> hudi-0.5.2-incubating-rc1/NOTICE
> hudi-0.5.2-incubating-rc1/hudi-common/src/test/resources/sample.data
> hudi-0.5.2-incubating-rc1/hudi-common/src/main/java/org/apache/hudi/common/util/ObjectSizeCalculator.java
> hudi-0.5.2-incubating-rc1/hudi-utilities/src/test/resources/IncrementalPull.sqltemplate
> 10:23:30 [hudi-0.5.2]$ grep -e "AvroConversionHelper" -e
> "ObjectSizeCalculator"  hudi-${RC_VERSION}-${RC_NUM}/LICENSE
> This product includes code from
> https://github.com/twitter/commons/blob/master/src/java/com/twitter/common/objectsize/ObjectSizeCalculator.java
> with the following license
> * org.apache.hudi.AvroConversionHelper copied from classes in
> org/apache/spark/sql/avro package
> 10:23:48 [hudi-0.5.2]$
> 
> 10:24:37 [scripts]$ ./release/validate_staged_release.sh --release=0.5.2
> --rc_num=1
> /tmp/validation_scratch_dir_001
> ~/Cache/hudi-0.5.2/hudi-0.5.2-incubating-rc1/scripts
> Checking Checksum of Source Release
> Checksum Check of Source Release - [OK]
> 
>   % Total    % Received % Xferd  Average Speed   Time    Time     Time
>  Current
>                                  Dload  Upload   Total   Spent    Left
>  Speed
> 100 21027  100 21027    0     0  50297      0 --:--:-- --:--:-- --:--:--
> 50303
> Checking Signature
> Signature Check - [OK]
> 
> Checking for binary files in source release
> No Binary Files in Source Release? - [OK]
> 
> Checking for DISCLAIMER
> DISCLAIMER file exists ? [OK]
> 
> Checking for LICENSE and NOTICE
> License file exists ? [OK]
> Notice file exists ? [OK]
> 
> Performing custom Licensing Check
> Licensing Check Passed [OK]
> 
> Running RAT Check
> RAT Check Passed [OK]
> 
> 10:26:15 [scripts]$
> 
> 
> On Thu, Mar 12, 2020 at 7:15 PM Suneel Marthi <[email protected]> wrote:
> 
> > +1 binding
> >
> > 1. Verified Sigs and hashes
> > 2. Downloaded tar and ran a maven compile
> > 3. Verified the NOTICE and License files.
> > 4. Ran thru the Quickstart guide.
> >
> >
> >
> > On Thu, Mar 12, 2020 at 9:01 PM vino yang <[email protected]> wrote:
> >
> > > Hi everyone,
> > >
> > >
> > > We have prepared the third apache release candidate for Apache Hudi
> > > (incubating). The version is: 0.5.2-incubating-rc1. Please review and
> > vote
> > > on the release candidate #1 for the version 0.5.2, as follows:
> > >
> > > [ ] +1, Approve the release
> > >
> > > [ ] -1, Do not approve the release (please provide specific comments)
> > >
> > > The complete staging area is available for your review, which includes:
> > >
> > > * JIRA release notes [1],
> > > * the official Apache source release and binary convenience releases to
> > be
> > > deployed to dist.apache.org [2], which are signed with the key with
> > > fingerprint C3A96EC77149571AE89F82764C86684D047DE03C [3],
> > >
> > > * all artifacts to be deployed to the Maven Central Repository [4],
> > > * source code tag "release-0.5.2-incubating-rc1" [5],
> > >
> > > The vote will be open for at least 72 hours. It is adopted by majority
> > > approval, with at least 3 PMC affirmative votes.
> > >
> > > Thanks,
> > >
> > > Vino
> > >
> > >
> > >
> > > [1]
> > >
> > >
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12322822&version=12346606
> > >
> > > [2]
> > >
> > >
> > https://dist.apache.org/repos/dist/dev/incubator/hudi/hudi-0.5.2-incubating-rc1/
> > >
> > > [3] https://dist.apache.org/repos/dist/release/incubator/hudi/KEYS
> > >
> > > [4]
> > https://repository.apache.org/content/repositories/orgapachehudi-1018/
> > >
> > > [5]
> > >
> > https://github.com/apache/incubator-hudi/tree/release-0.5.2-incubating-rc1
> > >
> >
> 

Reply via email to