Prashanth,
I think we should not be reverting clean operations here. Cleans are done on
the oldest file slices and a restore/rollback is not completely undoing the
work of clean that happened before it.
For incremental timeline syncing, embedded timeline server needs to read these
clean metadata to sync its cached file-system view.
Let me know your thoughts.
Balaji.V
On Wednesday, March 18, 2020, 11:23:09 AM PDT, Prashant Wason
<[email protected]> wrote:
HI Team,
I noticed that when a table is restored to a previous commit (
HoodieWriteClient::restoreToInstant
<https://github.com/apache/incubator-hudi/blob/master/hudi-client/src/main/java/org/apache/hudi/client/HoodieWriteClient.java#L735>),
only the COMMIT, DELTA_COMMIT and COMPACTION instants are rolled back and
their corresponding files are deleted from the timeline. If there are some
CLEAN instants, they are left over.
Is there a reason why CLEAN are not removed? Won't they be referring to
files which are no longer present and hence not useful?
Thanks
Prashant
