+1 (non-binding) did the same checks as rc1 - [OK] Checksums and signatures - [OK] NOTICE, DISCLAIM, LICENSE files exist - [OK] Compilation & tests (`mvn clean package`, `mvn clean package -Dscala-2.12`, `mvn clean package -DskipTests -DskipITs -Pspark-shade-unbundle-avro`) - [OK] Javadoc (`mvn clean javadoc:aggregate -Pjavadocs`) - [OK] Run quickstart
Btw, I've encountered the following while running ` ./release/validate_staged_release.sh --release=0.5.2 --rc_num=2` and it does not seem to be critical. Is there any local config I need to make to successfully run the command? Looks like others can run this command without any issue. Checking for binary files in source release There were non-text files in source release. Please check below ./docker/demo/data/batch_2.json: application/json; charset=us-ascii ./docker/demo/data/batch_1.json: application/json; charset=us-ascii ./hudi-common/src/test/resources/sample.data: application/json; charset=us-ascii Best, - Ethan On Sat, Mar 21, 2020 at 10:54 PM Bhavani Sudha <bhavanisud...@gmail.com> wrote: > +1 (non-binding) > > Did same tests as previous RC: > - Verified checksums and signatures [OK] > - Verified NOTICE, DISCLAIME, LICENSE files exist [OK] > - Downloaded and compiled succesfully [OK] > - Verified quickstart [OK] > - Ran some tests in IDE [OK] > > Thanks, > Sudha > > On Sat, Mar 21, 2020 at 7:43 PM Prasanna Rajaperumal <prasa...@apache.org> > wrote: > > > +1 binding > > > > (Hope we get past license/notice issues this time) > > > > On 2020/03/21 16:47:57, "vbal...@apache.org" <vbal...@apache.org> wrote: > > > +1 (binding) > > > > > > Ran following checks: > > > 1. Checked out RC candidate source code and compiled successfully > > > 2. Ran Apache Hudi quickstart steps successfully on > > 0.5.2-incubating-rc23. Ran release validation script successfully. > > > (base) varadarb-C02SH0P1G8WL:scripts varadarb$ > > ./release/validate_staged_release.sh --release=0.5.2 --rc_num=2 > > > > > > Checking Checksum of Source Release > > > > > > > > > Checksum Check of Source Release - [OK] > > > > > > > > > > > > Checking Signature > > > > > > Signature Check - [OK] > > > > > > Checking for binary files in source release > > > > > > > > > No Binary Files in Source Release? - [OK] > > > > > > Checking for DISCLAIMER > > > > > > DISCLAIMER file exists ? [OK] > > > > > > Checking for LICENSE and NOTICE > > > > > > License file exists ? [OK] > > > > > > Notice file exists ? [OK] > > > > > > Performing custom Licensing Check > > > > > > Licensing Check Passed [OK] > > > > > > Running RAT Check > > > RAT Check Passed [OK] > > > Balaji.V > > > > > > On Saturday, March 21, 2020, 08:23:44 AM PDT, Vinoth Chandar < > > vin...@apache.org> wrote: > > > > > > +1 binding > > > > > > Repeated tests from RC1 > > > > > > On Sat, Mar 21, 2020 at 5:44 AM vino yang <yanghua1...@gmail.com> > wrote: > > > > > > > +1 binding > > > > > > > > - checked signature & checksum > > > > - maven clean package -DskipTests > > > > - ran `release/validate_staged_release.sh` > > > > - check RAT (OK) > > > > > > > > Best, > > > > Vino > > > > > > > > Suneel Marthi <smar...@apache.org> 于2020年3月21日周六 下午8:33写道： > > > > > > > > > +1 binding > > > > > > > > > > - checked NOTICE and LICENSE > > > > > - verified checksum and signature > > > > > - mvn clean install > > > > > > > > > > > > > > > On Sat, Mar 21, 2020 at 7:01 AM leesf <leesf0...@gmail.com> wrote: > > > > > > > > > > > +1 (binding) > > > > > > > > > > > > - verified checksum and signature [OK] > > > > > > - mvn clean install -DskipTests [OK] > > > > > > - checked the modules in > > > > > > > > > > > > > > > > > > > > > > > > https://repository.apache.org/content/repositories/orgapachehudi-1019/org/apache/hudi/ > > > > > > [OK] > > > > > > > > > > > > Best, > > > > > > Leesf > > > > > > > > > > > > vino yang <yanghua1...@gmail.com> 于2020年3月21日周六 下午5:20写道： > > > > > > > > > > > > > Hi everyone, > > > > > > > > > > > > > > > > > > > > > We have prepared the third apache release candidate for Apache > > Hudi > > > > > > > (incubating). The version is: 0.5.2-incubating-rc2. Please > > review and > > > > > > vote > > > > > > > on the release candidate #2 for the version 0.5.2, as follows: > > > > > > > > > > > > > > [ ] +1, Approve the release > > > > > > > > > > > > > > [ ] -1, Do not approve the release (please provide specific > > comments) > > > > > > > > > > > > > > The complete staging area is available for your review, which > > > > includes: > > > > > > > > > > > > > > * JIRA release notes [1], > > > > > > > * the official Apache source release and binary convenience > > releases > > > > to > > > > > > be > > > > > > > deployed to dist.apache.org [2], which are signed with the key > > with > > > > > > > fingerprint C3A96EC77149571AE89F82764C86684D047DE03C [3], > > > > > > > > > > > > > > * all artifacts to be deployed to the Maven Central Repository > > [4], > > > > > > > * source code tag "release-0.5.2-incubating-rc2" [5], > > > > > > > > > > > > > > The vote will be open for at least 72 hours. It is adopted by > > > > majority > > > > > > > approval, with at least 3 PMC affirmative votes. > > > > > > > > > > > > > > Thanks, > > > > > > > > > > > > > > Vino > > > > > > > > > > > > > > > > > > > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12322822&version=12346606 > > > > > > > > > > > > > > [2] > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/hudi/hudi-0.5.2-incubating-rc2/ > > > > > > > > > > > > > > [3] > > https://dist.apache.org/repos/dist/release/incubator/hudi/KEYS > > > > > > > > > > > > > > [4] > > > > > > > > https://repository.apache.org/content/repositories/orgapachehudi-1019 > > > > > > > > > > > > > > [5] > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/incubator-hudi/tree/release-0.5.2-incubating-rc2 > > > > > > > > > > > > > > > > > > > > > > > > >
