Hi,

AFAIK codecov doesn't really work with the test framework. we only uplod
the corbetura reports collected locally in the build system.

Can you please verify that the local codecoverage reports pick up JUnit5
changes ?

-Ram

On Tue, Apr 14, 2020 at 2:49 PM Vinoth Chandar <[email protected]> wrote:

> This one is probably worth flagging with codecov support as well?
> Does seem weird.. :/
>
> On Mon, Apr 13, 2020 at 11:14 PM Shiyan Xu <[email protected]>
> wrote:
>
> > Hi all,
> >
> > We're migrating all test cases to JUnit 5.
> >
> > This PR, as an initial step to enable JUnit 5, has migrated quite a few
> > test cases. The test cases pass in green with no issue.
> >
> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_incubator-2Dhudi_pull_1504&d=DwIBaQ&c=r2dcLCtU9q6n0vrtnDw9vg&r=KLmNyF_KPBPNb-BIVUsy8j_1tYfqyNa57jwVia1c9kM&m=N-aQ9xRn8pYpDY14UF6eW6uheElz-yPJJeF2t4iSnQc&s=rGcSb-T2BFSi6WdXoQAaMGCHMFUBUvFa2rkn31OXf6w&e=
> >
> > However, as you can see in the Codecov comment, the coverage decreased
> > quite a bit. It's been observed that the test cases ran by JUnit 5 were
> > somehow omitted in the report and resulted in the decrease.
> >
> > Is there anyone familiar with the Codecov settings? Or happen to know
> > Codecov experts?
> > I created this ticket for investigation. Any hint/suggestion on
> > troubleshooting this will be highly appreciated. Please feel free to
> > response to the thread or comment in the ticket.
> >
> https://urldefense.proofpoint.com/v2/url?u=https-3A__jira.apache.org_jira_browse_HUDI-2D792&d=DwIBaQ&c=r2dcLCtU9q6n0vrtnDw9vg&r=KLmNyF_KPBPNb-BIVUsy8j_1tYfqyNa57jwVia1c9kM&m=N-aQ9xRn8pYpDY14UF6eW6uheElz-yPJJeF2t4iSnQc&s=FpOe2NEJMjMsa6gvvuvi1N9YXQFRjweDMCSMYyqwtsk&e=
> >
> > Thank you.
> >
> > Regards,
> > Raymond
> >
>

Reply via email to