+1 non-binding

Ran tests and ITs locally
Ran release validation script.

Best Regards,
Gary Li
 

On 6/11/20, 10:21 PM, "leesf" <[email protected]> wrote:

    +1 binding

    Compiled from source.
    Verified signs and hashes

    PS: When running quickstart. I found it became slow to finish the insert,
    maybe caused by turning on `hoodie.embed.timeline.server` on default? after
    setting `hoodie.embed.timeline.server` to false, it became normal.

    Suneel Marthi <[email protected]> 于2020年6月12日周五 上午11:07写道:

    > +1 binding
    >
    > Compiled from source
    > Verified sigs and hashes
    >
    > On Thu, Jun 11, 2020 at 11:04 PM vino yang <[email protected]> wrote:
    >
    > > +1  (binding)
    > >
    > > * compiled the source code [OK]
    > > * ran all the tests(except IT tests) in my local [OK]
    > > * checked release note [OK]
    > >
    > > Best,
    > > Vino
    > >
    > > hddong <[email protected]> 于2020年6月12日周五 上午8:58写道:
    > >
    > > > +1
    > > >
    > > > Mehrotra, Udit <[email protected]> 于2020年6月12日周五 上午7:06写道:
    > > >
    > > > > +1 (non-binding)
    > > > >
    > > > > - Integration tests succeeded locally
    > > > > - Release validation script succeeded:
    > > > >         Checking Signature
    > > > >         -e              Signature Check - [OK]
    > > > >
    > > > >         Checking for binary files in source release
    > > > >         -e              No Binary Files in Source Release? - [OK]
    > > > >
    > > > >         Checking for DISCLAIMER
    > > > >         -e              DISCLAIMER file exists ? [OK]
    > > > >
    > > > >         Checking for LICENSE and NOTICE
    > > > >         -e              License file exists ? [OK]
    > > > >         -e              Notice file exists ? [OK]
    > > > >
    > > > >         Performing custom Licensing Check
    > > > >         -e              Licensing Check Passed [OK]
    > > > >
    > > > >         Running RAT Check
    > > > >         -e              RAT Check Passed [OK]
    > > > > - Ran some basic COW/MOR tests on EMR cluster with this releases
    > jars.
    > > > >
    > > > > Thanks,
    > > > > Udit
    > > > >
    > > > > On 6/11/20, 1:51 PM, "nishith agarwal" <[email protected]> wrote:
    > > > >
    > > > >     CAUTION: This email originated from outside of the organization.
    > Do
    > > > > not click links or open attachments unless you can confirm the 
sender
    > > and
    > > > > know the content is safe.
    > > > >
    > > > >
    > > > >
    > > > >     +1 (binding)
    > > > >
    > > > >     - Ran tests locally
    > > > >     - Release script successful
    > > > >
    > > > >     Checking Signature
    > > > >
    > > > >     Signature Check - [OK]
    > > > >
    > > > >
    > > > >     Checking for binary files in source release
    > > > >
    > > > >     No Binary Files in Source Release? - [OK]
    > > > >
    > > > >
    > > > >     Checking for DISCLAIMER
    > > > >
    > > > >     DISCLAIMER file exists ? [OK]
    > > > >
    > > > >
    > > > >     Checking for LICENSE and NOTICE
    > > > >
    > > > >     License file exists ? [OK]
    > > > >
    > > > >     Notice file exists ? [OK]
    > > > >
    > > > >
    > > > >     Performing custom Licensing Check
    > > > >
    > > > >     Licensing Check Passed [OK]
    > > > >
    > > > >
    > > > >     Running RAT Check
    > > > >
    > > > >     RAT Check Passed [OK]
    > > > >
    > > > >     Thanks,
    > > > >     Nishith
    > > > >
    > > > >     On Thu, Jun 11, 2020 at 10:55 AM [email protected] <
    > > > > [email protected]>
    > > > >     wrote:
    > > > >
    > > > >     >
    > > > >     > +1(binding)
    > > > >     > 1. Ran integration tests locally2. Manually reviewed the
    > commits
    > > > > landing
    > > > >     > into 0.5.3 by comparing against 0.5.2 3. Ran deltastreamer in
    > > > > continuous
    > > > >     > mode with async compaction for couple of hours on test data 
and
    > > > > verified no
    > > > >     > errors.4. Release Validation script passed locally. ```
    > > > >     > varadarb-C02SH0P1G8WL:scripts varadarb$
    > > > >     > ./release/validate_staged_release.sh --release=0.5.3 
--rc_num=2
    > > > >     >
    > > > >     > /tmp/validation_scratch_dir_001 ~/projects/new_ws/hudi/scripts
    > > > >     >
    > > > >     > Checking Checksum of Source Release
    > > > >     >
    > > > >     >   Checksum Check of Source Release - [OK]
    > > > >     >
    > > > >     >
    > > > >     >
    > > > >     >
    > > > >     >   % Total    % Received % Xferd  Average Speed   Time    Time
    > > > >  Time
    > > > >     > Current
    > > > >     >
    > > > >     >                                  Dload  Upload   Total   Spent
    > > > > Left
    > > > >     > Speed
    > > > >     >
    > > > >     > 100 26722  100 26722    0     0  48234      0 --:--:-- 
--:--:--
    > > > > --:--:--
    > > > >     > 48234
    > > > >     >
    > > > >     > Checking Signature
    > > > >     >
    > > > >     >   Signature Check - [OK]
    > > > >     >
    > > > >     >
    > > > >     >
    > > > >     >
    > > > >     > Checking for binary files in source release
    > > > >     >
    > > > >     >   No Binary Files in Source Release? - [OK]
    > > > >     >
    > > > >     >
    > > > >     >
    > > > >     >
    > > > >     > Checking for DISCLAIMER
    > > > >     >
    > > > >     >   DISCLAIMER file exists ? [OK]
    > > > >     >
    > > > >     >
    > > > >     >
    > > > >     >
    > > > >     > Checking for LICENSE and NOTICE
    > > > >     >
    > > > >     >   License file exists ? [OK]
    > > > >     >
    > > > >     >   Notice file exists ? [OK]
    > > > >     >
    > > > >     >
    > > > >     >
    > > > >     >
    > > > >     > Performing custom Licensing Check
    > > > >     >
    > > > >     >   Licensing Check Passed [OK]
    > > > >     >
    > > > >     >
    > > > >     >
    > > > >     >
    > > > >     > Running RAT Check
    > > > >     >
    > > > >     >   RAT Check Passed [OK]
    > > > >     >
    > > > >     >
    > > > >     >
    > > > >     >
    > > > >     > ~/projects/new_ws/hudi/scripts
    > > > >     >
    > > > >     > varadarb-C02SH0P1G8WL:scripts varadarb$ echo $?
    > > > >     >
    > > > >     > 0
    > > > >     > ```
    > > > >     >     On Wednesday, June 10, 2020, 02:57:35 PM PDT, Sivabalan <
    > > > >     > [email protected]> wrote:
    > > > >     >
    > > > >     >  Hi everyone,
    > > > >     >
    > > > >     > Please review and vote on the release candidate #2 for the
    > > version
    > > > > 0.5.3,
    > > > >     > as follows:
    > > > >     > [ ] +1, Approve the release
    > > > >     > [ ] -1, Do not approve the release (please provide specific
    > > > comments)
    > > > >     >
    > > > >     >  The complete staging area is available for your review, which
    > > > > includes:
    > > > >     >
    > > > >     > * JIRA release notes [1],
    > > > >     > * the official Apache source release and binary convenience
    > > > releases
    > > > > to be
    > > > >     > deployed to dist.apache.org [2], which are signed with the key
    > > > with
    > > > >     > fingerprint 001B66FA2B2543C151872CCC29A4FD82F1508833 [3],
    > > > >     > * all artifacts to be deployed to the Maven Central Repository
    > > [4],
    > > > >     > * source code tag "release-0.5.3-rc2" [5],
    > > > >     >
    > > > >     > The vote will be open for at least 72 hours. It is adopted by
    > > > > majority
    > > > >     > approval, with at least 3 PMC affirmative votes.
    > > > >     >
    > > > >     >
    > > > >     > Thanks,
    > > > >     > Release Manager
    > > > >     >
    > > > >     > [1]
    > > > >     >
    > > > >     >
    > > > >
    > > >
    > >
    > 
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12322822&version=12348256
    > > > >     >
    > > > >     > [2]
    > https://dist.apache.org/repos/dist/dev/hudi/hudi-0.5.3-rc2/
    > > > >     >
    > > > >     > [3] https://dist.apache.org/repos/dist/release/hudi/KEYS
    > > > >     >
    > > > >     > [4]
    > > > >
    > https://repository.apache.org/content/repositories/orgapachehudi-1023/
    > > > >     >
    > > > >     > [5] https://github.com/apache/hudi/tree/release-0.5.3-rc2
    > > > >     >
    > > > >
    > > > >
    > > > >
    > > >
    > >
    >

Reply via email to