Hi, This is another issue that needs to be addressed I think.
Checking for binary files in source release There were non-text files in source release. Please check below ./hudi-flink/src/test/resources/test_source_5.data: application/csv; charset=us-ascii Thanks Vinoth On Tue, Aug 17, 2021 at 7:48 AM Vinoth Chandar <vin...@apache.org> wrote: > -1 (binding) > > An issue was surfaced yesterday, that affects the re-definition of some > configs in HoodieWriteConfig e.g TABLE_NAME, AVRO_SCHEMA, > AVRO_SCHEMA_VALIDATE > which unfortunately do not have the _PROP suffix added. These are now > re-defining as ConfigProperty members now and jobs using them directly (we > have such usages > even in our quickstart) will have to break upon upgrading to this release. > While, its a bit of a step back to have to rename these to something else, > it might make sense > to keep all such members without _PROP suffix as string and make the new > members TABLE_NAME_CFG etc, to avoid upgrade pain. > > I am also testing the RC for other issues, will update the thread again > with findings. > > Thanks > Vinoth > > On Sun, Aug 15, 2021 at 6:05 PM Raymond Xu <xu.shiyan.raym...@gmail.com> > wrote: > >> Ok the Azure CI passed with the patch so the missing test coverage is >> proved not an issue >> >> https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=1770&view=results >> >> reverse my -1 to +1 >> >> On Sun, Aug 15, 2021 at 5:10 PM Raymond Xu <xu.shiyan.raym...@gmail.com> >> wrote: >> >> > Hey Udit, sorry I'm -1 due to a misconfigured test resulting in some >> test >> > cases getting skipped. The patch was merged to master. >> > https://github.com/apache/hudi/pull/3476/files >> > >> > Created a hotfix PR to the release branch. >> > https://github.com/apache/hudi/pull/3480/files >> > >> > >> > On Sun, Aug 15, 2021 at 4:22 PM Udit Mehrotra <udi...@apache.org> >> wrote: >> > >> >> Hi everyone, >> >> >> >> Please review and vote on the release candidate #1 for the version >> 0.9.0, >> >> as follows: >> >> >> >> [ ] +1, Approve the release >> >> >> >> [ ] -1, Do not approve the release (please provide specific comments) >> >> >> >> The complete staging area is available for your review, which includes: >> >> >> >> * JIRA release notes [1], >> >> >> >> * the official Apache source release and binary convenience releases >> to be >> >> deployed to dist.apache.org [2], which are signed with the key with >> >> fingerprint 44A484600E48193A74F97447C47E66F8386204DF [3], >> >> >> >> * all artifacts to be deployed to the Maven Central Repository [4], >> >> >> >> * source code tag "release-0.9.0-rc1" [5], >> >> >> >> The vote will be open for at least 72 hours. It is adopted by majority >> >> approval, with at least 3 PMC affirmative votes. >> >> >> >> Thanks, >> >> >> >> Release Manager >> >> >> >> [1] >> >> >> >> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12322822&version=12350027 >> >> >> >> [2] https://dist.apache.org/repos/dist/dev/hudi/hudi-0.9.0-rc1/ >> >> >> >> [3] https://dist.apache.org/repos/dist/dev/hudi/KEYS >> >> >> >> [4] >> >> >> >> >> https://repository.apache.org/content/repositories/orgapachehudi-1042/org/apache/hudi/ >> >> >> >> [5] https://github.com/apache/hudi/tree/release-0.9.0-rc1 >> >> >> > >> >
