Thanks for Alexey and Ethan's replies, we will continue to freeze the code according to the estimated 09/28 11:59 PST.
Thanks, - Zhaojing Y Ethan Guo <yi...@apache.org> 于2022年9月28日周三 00:47写道： > Hi Zhaojing, > > Thanks for raising this. As Alexey mentioned, the authors feel > comfortable landing the PRs by the current code freeze time. Maybe you can > re-evaluate the situation Wednesday morning PT? > > Thanks, > - Ethan > > On Tue, Sep 27, 2022 at 9:11 AM Alexey Kudinkin <ale...@onehouse.ai> > wrote: > > > Zhaojing, we synced up with the authors of the aforementioned PRs, and > > everyone feels comfortable that we should be able to land these w/in the > > currently set deadline of 09/28 11:59 PST. > > > > As such, i'd suggest we keep the existing deadline intact to avoid > delaying > > the release. What do you think? > > > > On Tue, Sep 27, 2022 at 3:37 AM zhaojing yu <maidou...@gmail.com> wrote: > > > > > Hi folks, > > > > > > There are still a few critical PRs are pending, e.g., > > > HUDI-2780 <https://github.com/apache/hudi/pull/4015>, > > > HUDI-3636 <https://github.com/apache/hudi/pull/5269>, > > > HUDI-4453 <https://github.com/apache/hudi/pull/6676>, > > > HUDI-4687 <https://github.com/apache/hudi/pull/6657>, > > > HUDI-4855 <https://github.com/apache/hudi/pull/6694>, etc. > > > > > > We should get those landed for 0.12.1. > > > In mind, I'm proposing a new date for code freeze *Oct 2nd, 11:59 PM > > PST*. > > > Kindlky let me know if you hava any concerns. > > > > > > > > > Thanks, > > > - Zhaojing > > > > > > zhaojing yu <maidou...@gmail.com> 于2022年9月23日周五 15:10写道： > > > > > > > After discussion our goal will be to freeze the code on 28th Sep. > > > > Until then I will follow the progress of the above blocker pr. > > > > > > > > Sivabalan <n.siv...@gmail.com> 于2022年9月21日周三 11:02写道： > > > > > > > >> We are targeting to land all of these by 28th Sep. We will try our > > best > > > to > > > >> land them before starting of next week, but 28th would be more > > > practical. > > > >> > > > >> On Tue, 20 Sept 2022 at 18:21, Vinoth Chandar <vin...@apache.org> > > > wrote: > > > >> > > > >> > Thanks for sharing. Do we have an ETA for these? > > > >> > > > > >> > Zhaojing - please chime with your thoughts as well > > > >> > > > > >> > On Wed, Sep 21, 2022 at 06:34 Y Ethan Guo <yi...@apache.org> > wrote: > > > >> > > > > >> > > Hi Zhaojing, > > > >> > > > > > >> > > It would be good if we can land the following bootstrap fixes > for > > > >> 0.12.1 > > > >> > > release. I'm working on getting them merged. > > > >> > > > > > >> > > HUDI-4855: https://github.com/apache/hudi/pull/6694 > > > >> > > HUDI-4453: https://github.com/apache/hudi/pull/6676 > > > >> > > > > > >> > > Thanks, > > > >> > > - Ethan > > > >> > > > > > >> > > On Tue, Sep 20, 2022 at 12:03 PM Alexey Kudinkin < > > > ale...@onehouse.ai> > > > >> > > wrote: > > > >> > > > > > >> > > > There are also a few critical issues we want to address before > > > >> cutting > > > >> > > the > > > >> > > > 0.12.1 release: > > > >> > > > > > > >> > > > HUDI-4760 <https://issues.apache.org/jira/browse/HUDI-4760> > > > >> > > > HUDI-3636 <https://issues.apache.org/jira/browse/HUDI-3636> > > > >> > > > HUDI-4885 <https://issues.apache.org/jira/browse/HUDI-4885> > > > >> > > > HUDI-2780 <https://issues.apache.org/jira/browse/HUDI-2780> > > > >> > > > > > > >> > > > On Tue, Sep 20, 2022 at 10:14 AM Sivabalan < > n.siv...@gmail.com> > > > >> wrote: > > > >> > > > > > > >> > > > > sure. We have few critical PRs that we are looking to land. > > Few > > > >> > notable > > > >> > > > > ones are > > > >> > > > > > > > >> > > > > ClassNotFoundException when using hudi-spark-bundle to write > > > table > > > >> > with > > > >> > > > > hbase index <https://github.com/apache/hudi/pull/6715> > > > >> > > > > Fix fq can not be queried in pending compaction when query > ro > > > >> table > > > >> > > with > > > >> > > > > spark <https://github.com/apache/hudi/pull/6516> > > > >> > > > > Syncing non-partitioned table has bugs around partition > > > parameters > > > >> > > > > <https://github.com/apache/hudi/pull/6525> > > > >> > > > > bootstrap bug fixes: > https://github.com/apache/hudi/pull/6694 > > > and > > > >> > > > > https://github.com/apache/hudi/pull/6676 > > > >> > > > > > > > >> > > > > > > > >> > > > > On Mon, 19 Sept 2022 at 20:24, Vinoth Chandar < > > > vin...@apache.org> > > > >> > > wrote: > > > >> > > > > > > > >> > > > > > tbh the RM can make this call. Whether or not 1 week is > > > >> aggressive, > > > >> > > > > really > > > >> > > > > > depends on the scope of release, whats left to land/test. > > > >> > > > > > > > > >> > > > > > Would it be useful to frame the discussion in that way? > > > >> > > > > > > > > >> > > > > > On Mon, Sep 19, 2022 at 1:25 PM zhaojing yu < > > > >> maidou...@gmail.com> > > > >> > > > wrote: > > > >> > > > > > > > > >> > > > > > > Do anyone else have any suggestions? > > > >> > > > > > > We will determine the time of the code freeze tomorrow. > > > >> > > > > > > > > > >> > > > > > > Sivabalan <n.siv...@gmail.com> 于2022年9月19日周一 14:05写道： > > > >> > > > > > > > > > >> > > > > > > > Hey hi Zhaojing, > > > >> > > > > > > > Announcing a code freeze just 1 week ahead might > > be > > > >> too > > > >> > > > > > aggressive. > > > >> > > > > > > > Do you think, we can make it sometime next week(week > of > > > >> 26th) > > > >> > to > > > >> > > > give > > > >> > > > > > > some > > > >> > > > > > > > buffer for folks to push any critical fixes in. Open > to > > > hear > > > >> > what > > > >> > > > > > others > > > >> > > > > > > > have to say. > > > >> > > > > > > > > > > >> > > > > > > > > > > >> > > > > > > > > > > >> > > > > > > > On Fri, 16 Sept 2022 at 01:47, zhaojing yu < > > > >> > maidou...@gmail.com> > > > >> > > > > > wrote: > > > >> > > > > > > > > > > >> > > > > > > > > To clarify, 09/21 is to cut RC1 and it will be > > released > > > if > > > >> > all > > > >> > > > > > > > > testing/checks pass. > > > >> > > > > > > > > > > > >> > > > > > > > > zhaojing yu <maidou...@gmail.com> 于2022年9月16日周五 > > > 16:45写道： > > > >> > > > > > > > > > > > >> > > > > > > > > > Hi folks, > > > >> > > > > > > > > > > > > >> > > > > > > > > > As the RM for the 0.12.1 release, I'd like to > > propose > > > >> the > > > >> > > code > > > >> > > > > > freeze > > > >> > > > > > > > on > > > >> > > > > > > > > > Sep 21 (Wed) for any bug fixes that are going to > be > > > >> > included > > > >> > > in > > > >> > > > > the > > > >> > > > > > > > minor > > > >> > > > > > > > > > release, about a month after the 0.12.0 release. > > Let > > > me > > > >> > know > > > >> > > > if > > > >> > > > > > you > > > >> > > > > > > > need > > > >> > > > > > > > > > more time for fixing any issues. > > > >> > > > > > > > > > > > > >> > > > > > > > > > Please tag any fix that you think we should > include > > in > > > >> > > 0.12.1, > > > >> > > > by > > > >> > > > > > > > setting > > > >> > > > > > > > > > the "Fix Version/s" to "0.12.1" in the > corresponding > > > >> Jira > > > >> > > > ticket. > > > >> > > > > > As > > > >> > > > > > > > the > > > >> > > > > > > > > > RM, I will make the final decision. I have > started > > > >> > > > > cherry-picking > > > >> > > > > > > the > > > >> > > > > > > > > > commits from the master. I will watch out for > > ongoing > > > >> > > critical > > > >> > > > > > fixes > > > >> > > > > > > > and > > > >> > > > > > > > > > remind authors and reviewers in the PRs along the > > way > > > so > > > >> > they > > > >> > > > can > > > >> > > > > > > land > > > >> > > > > > > > in > > > >> > > > > > > > > > time. > > > >> > > > > > > > > > > > > >> > > > > > > > > > cherry-picking link： > > > >> > > > > > > > > > > > > >> > > > > > > > > > > > >> > > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > > > > https://docs.google.com/document/d/1G4eeZkSUqMgONRI2YE0o_XBxy9kBaq_Cznolfp2VhS8/edit#heading=h.3fl3egu0kv0z > > > >> > > > > > > > > > > > > >> > > > > > > > > > Thanks, > > > >> > > > > > > > > > - Zhaojing > > > >> > > > > > > > > > > > > >> > > > > > > > > > > > >> > > > > > > > > > > >> > > > > > > > > > > >> > > > > > > > -- > > > >> > > > > > > > Regards, > > > >> > > > > > > > -Sivabalan > > > >> > > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > > >> > > > > -- > > > >> > > > > Regards, > > > >> > > > > -Sivabalan > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > > >> -- > > > >> Regards, > > > >> -Sivabalan > > > >> > > > > > > > > > >
