Apologies for the confusion! I missed that the reverting commit has already been successfully cherry-picked.
Taking back my -1, and voting +1 (non-binding) On Tue, Oct 4, 2022 at 9:46 PM Y Ethan Guo <yi...@apache.org> wrote: > +1 (non-binding) > > - [OK] checksums and signatures > - [OK] ran release validation script > - [OK] built successfully > - [OK] error injection tests > - [OK] table upgrade and downgrade tests > > On Tue, Oct 4, 2022 at 11:06 PM zhaojing yu <maidou...@gmail.com> wrote: > > > This commit has been reverted in version 0.12.1. > > > > Alexey Kudinkin <ale...@onehouse.ai> 于2022年10月5日周三 03:45写道： > > > > > -1 > > > > > > Unfortunately, we will have to revert > > > commit 830e35c3f1d5663c9e96d36da4af67928e9d598b, as it plants a > > performance > > > regression that the author is currently working on to address. > > > > > > > > > On Tue, Oct 4, 2022 at 10:08 AM Sivabalan <n.siv...@gmail.com> wrote: > > > > > > > Sorry about that. Raymond referred me to apache policy around license > > > > headers < > https://www.apache.org/legal/src-headers.html#faq-exceptions > > >. > > > > So, > > > > reverting my vote to +1. > > > > > > > > Ran Deltastreamer tests, lock provider tests, structured spark > > streaming > > > > tests. > > > > > > > > On Tue, 4 Oct 2022 at 08:48, zhaojing yu <maidou...@gmail.com> > wrote: > > > > > > > > > Confirm in > > > https://www.apache.org/legal/src-headers.html#faq-exceptions > > > > > that such files do not require LICENSE HEADER, have been modified > > > > > validate_staged_release.sh skip the corresponding checks. > > > > > > > > > > Sivabalan <n.siv...@gmail.com> 于2022年10月4日周二 12:01写道： > > > > > > > > > > > -1 Looks like we missed to add license header to a text file. > > > > > > > > > > > > ./release/validate_staged_release.sh --release=0.12.1 --rc_num=1 > > > > > > /tmp/validation_scratch_dir_001 > > > > > > ~/Documents/personal/projects/nov26/hudi/scripts > > > > > > Downloading from svn co > > https://dist.apache.org/repos/dist/dev/hudi > > > > > > Validating hudi-0.12.1-rc1 with release type "dev" > > > > > > Checking Checksum of Source Release > > > > > > Checksum Check of Source Release - [OK] > > > > > > > > > > > > % Total % Received % Xferd Average Speed Time Time > > > Time > > > > > > Current > > > > > > Dload Upload Total Spent > > > Left > > > > > > Speed > > > > > > 100 65803 100 65803 0 0 116k 0 --:--:-- --:--:-- > > > > --:--:-- > > > > > > 116k > > > > > > Checking Signature > > > > > > Signature Check - [OK] > > > > > > > > > > > > Checking for binary files in source release > > > > > > No Binary Files in Source Release? - [OK] > > > > > > > > > > > > Checking for DISCLAIMER > > > > > > DISCLAIMER file exists ? [OK] > > > > > > > > > > > > Checking for LICENSE and NOTICE > > > > > > License file exists ? [OK] > > > > > > Notice file exists ? [OK] > > > > > > > > > > > > Performing custom Licensing Check > > > > > > There were some source files that did not have Apache > > > > > > License*./hudi-cli/src/main/resources/banner.txt* > > > > > > > > > > > > > > > > > > On Sat, 1 Oct 2022 at 05:56, zhaojing yu <maidou...@gmail.com> > > > wrote: > > > > > > > > > > > > > Hi everyone, > > > > > > > > > > > > > > Please review and vote on the release candidate #1 for the > > version > > > > > > 0.12.1, > > > > > > > as follows: > > > > > > > > > > > > > > [ ] +1, Approve the release > > > > > > > [ ] -1, Do not approve the release (please provide specific > > > comments) > > > > > > > > > > > > > > The complete staging area is available for your review, which > > > > includes: > > > > > > > > > > > > > > * JIRA release notes [1], > > > > > > > * the official Apache source release and binary convenience > > > releases > > > > to > > > > > > be > > > > > > > deployed to dist.apache.org [2], which are signed with the key > > > with > > > > > > > fingerprint B4305519F36DD7E8B7E6A68458B85B8147783CE2 [3], > > > > > > > * all artifacts to be deployed to the Maven Central Repository > > [4], > > > > > > > * source code tag "release-0.12.1-rc1" [5], > > > > > > > > > > > > > > The vote will be open for at least 72 hours. It is adopted by > > > > majority > > > > > > > approval, with at least 3 PMC affirmative votes. > > > > > > > > > > > > > > Thanks, > > > > > > > Release Manager > > > > > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12322822&version=12352182 > > > > > > > [2] > https://dist.apache.org/repos/dist/dev/hudi/hudi-0.12.1-rc1/ > > > > > > > [3] https://dist.apache.org/repos/dist/dev/hudi/KEYS > > > > > > > [4] > > > > > > > > > https://repository.apache.org/content/repositories/orgapachehudi-1093/ > > > > > > > [5] > > https://github.com/apache/hudi/releases/tag/release-0.12.1-rc1 > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > Regards, > > > > > > -Sivabalan > > > > > > > > > > > > > > > > > > > > > > > -- > > > > Regards, > > > > -Sivabalan > > > > > > > > > >
