javeme commented on code in PR #1842:
URL:
https://github.com/apache/incubator-hugegraph/pull/1842#discussion_r858270768
##########
hugegraph-test/src/main/java/com/baidu/hugegraph/core/TaskCoreTest.java:
##########
@@ -591,11 +613,11 @@ public void testGremlinJobAndRestore() throws Exception {
HugeGraph graph = graph();
TaskScheduler scheduler = graph.taskScheduler();
- String gremlin = "System.out.println('task start');" +
+ String gremlin = "LOG.info(\"task start\");" +
Review Comment:
maybe there is no LOG import, can try groovy `println`
##########
hugegraph-test/src/main/java/com/baidu/hugegraph/core/VertexCoreTest.java:
##########
@@ -2703,13 +2703,6 @@ public void testQueryOlapWithUpdates() {
graph.readMode(GraphReadMode.ALL);
// FIXME: expect to throw error here
-// Assert.assertThrows(IllegalArgumentException.class, () -> {
-// graph.traversal().V().has("pagerank", 0.1D).toList();
-// }, e -> {
-// Assert.assertContains("not allowed to query by olap " +
-// "when there are uncommitted records",
-// e.toString());
-// });
Review Comment:
can we keep this code block?
##########
hugegraph-test/src/main/java/com/baidu/hugegraph/core/AuthTest.java:
##########
@@ -110,9 +110,9 @@ public void testCreateUser() {
Assert.assertThrows(IllegalArgumentException.class, () -> {
authManager.createUser(makeUser("tom", "pass1"));
}, e -> {
- Assert.assertContains("Can't save user", e.getMessage());
- Assert.assertContains("that already exists", e.getMessage());
- });
+ Assert.assertContains("Can't save user", e.getMessage());
Review Comment:
can we keep the origin indentation style?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
