javeme commented on code in PR #1854:
URL:
https://github.com/apache/incubator-hugegraph/pull/1854#discussion_r864429335
##########
hugegraph-core/src/main/java/com/baidu/hugegraph/job/computer/AbstractComputer.java:
##########
@@ -117,7 +114,7 @@ public Object call(Job<Object> job, Map<String, Object>
parameters) {
Process process = builder.start();
StringBuilder output = new StringBuilder();
- try(LineNumberReader reader = new LineNumberReader(
+ try (LineNumberReader reader = new LineNumberReader(
Review Comment:
also update alignment of line 118
##########
hugegraph-core/src/main/java/com/baidu/hugegraph/schema/builder/PropertyKeyBuilder.java:
##########
@@ -69,8 +69,8 @@ public PropertyKeyBuilder(SchemaTransaction transaction,
this.checkExist = true;
}
- public PropertyKeyBuilder(SchemaTransaction transaction,
- HugeGraph graph, PropertyKey copy) {
+ public PropertyKeyBuilder(SchemaTransaction transaction, HugeGraph graph,
Review Comment:
prefer to keep old style (don't exceed guide line length 80 chars)
##########
hugegraph-core/src/main/java/com/baidu/hugegraph/schema/builder/PropertyKeyBuilder.java:
##########
@@ -44,7 +44,7 @@
import com.baidu.hugegraph.util.E;
public class PropertyKeyBuilder extends AbstractBuilder
- implements PropertyKey.Builder {
+ implements PropertyKey.Builder {
Review Comment:
prefer to keep old style
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
