javeme commented on code in PR #1984:
URL:
https://github.com/apache/incubator-hugegraph/pull/1984#discussion_r1010391281
##########
hugegraph-core/src/main/java/com/baidu/hugegraph/job/algorithm/SubgraphStatAlgorithm.java:
##########
@@ -23,6 +23,7 @@
import java.util.Map;
import org.apache.commons.configuration.PropertiesConfiguration;
+import org.apache.commons.configuration2.Configuration;
Review Comment:
there are still compile errors like `package javax.inject does not exist`
##########
hugegraph-core/src/main/java/com/baidu/hugegraph/job/algorithm/AbstractAlgorithm.java:
##########
@@ -382,9 +381,7 @@ protected Iterator<Vertex> vertices(Object label, long
limit) {
ConditionQuery query = new ConditionQuery(HugeType.VERTEX);
query.capacity(Query.NO_CAPACITY);
query.limit(limit);
- if (label != null) {
- query.eq(HugeKeys.LABEL, this.getVertexLabelId(label));
- }
+ query.eq(HugeKeys.LABEL, this.getVertexLabelId(label));
Review Comment:
keep `if (label != null)` statement to avoid label=null condition
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]