javeme commented on code in PR #2002:
URL:
https://github.com/apache/incubator-hugegraph/pull/2002#discussion_r1011876017
##########
hugegraph-rocksdb/src/main/java/com/baidu/hugegraph/backend/store/rocksdb/RocksDBTable.java:
##########
@@ -291,7 +291,7 @@ public boolean isOlap() {
return false;
}
- protected static final BackendEntryIterator newEntryIterator(
+ protected static BackendEntryIterator newEntryIterator(
Review Comment:
update alignment of the next line
##########
hugegraph-rocksdb/src/main/java/com/baidu/hugegraph/backend/store/rocksdb/RocksDBStdSessions.java:
##########
@@ -954,11 +954,10 @@ public void deleteSingle(String table, byte[] key) {
*/
@Override
public void deletePrefix(String table, byte[] key) {
- byte[] keyFrom = key;
byte[] keyTo = Arrays.copyOf(key, key.length);
- keyTo = BinarySerializer.increaseOne(keyTo);
+ BinarySerializer.increaseOne(keyTo);
try (CFHandle cf = cf(table)) {
- this.batch.deleteRange(cf.get(), keyFrom, keyTo);
+ this.batch.deleteRange(cf.get(), key, keyTo);
Review Comment:
better to keep the origin keyFrom var for more readable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
