[GitHub] [incubator-hugegraph] imbajin commented on a diff in pull request #1984: feat(core): add a string of OLAP algorithms

[GitBox]

imbajin commented on code in PR #1984:
URL: 
https://github.com/apache/incubator-hugegraph/pull/1984#discussion_r1013017071


##########
hugegraph-core/src/main/java/com/baidu/hugegraph/job/algorithm/comm/LouvainTraverser.java:
##########
@@ -321,9 +319,7 @@ private Community wrapCommunity(Vertex v, List<Edge> nbs) {
         return comm;
     }
 
-    private Collection<Pair<Community, MutableInt>> nbCommunities(
-                                                    int pass,
-                                                    List<Edge> edges) {
+    private Collection<Pair<Community, MutableInt>> nbCommunities(int pass, 
List<Edge> edges) {

Review Comment:
   in fact, It doesn't seem necessary, compare the 2 align, maybe one line is 
better (when it < 100 chars)
   
   old:
   <img width="876" alt="image" 
src="https://user-images.githubusercontent.com/17706099/199755050-23267663-94c3-4041-a56d-c50474e5a6c1.png";>
   
   new:
   <img width="864" alt="image" 
src="https://user-images.githubusercontent.com/17706099/199755124-dc4640f6-a27e-4142-9c32-3a62755e47d1.png";>
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org