imbajin commented on code in PR #2033:
URL:
https://github.com/apache/incubator-hugegraph/pull/2033#discussion_r1031655911
##########
hugegraph-api/pom.xml:
##########
@@ -186,7 +186,7 @@
</manifest>
<manifestEntries>
<!-- TODO: update it -->
-
<Implementation-Version>0.69.0.0</Implementation-Version>
+
<Implementation-Version>${project.version}</Implementation-Version>
Review Comment:
seems we should keep it now, it's APIversion
##########
hugegraph-api/src/main/java/org/apache/hugegraph/version/ApiVersion.java:
##########
@@ -122,11 +122,11 @@ public final class ApiVersion {
* The second parameter of Version.of() is for IDE running without JAR
* TODO: what shall we set for this version? (consider the basic
compatibility)
*/
- public static final Version VERSION = Version.of(ApiVersion.class, "0.69");
+ public static final Version VERSION = Version.of(ApiVersion.class,
"1.0.0");
public static void check() {
// Check version of hugegraph-core. Firstly do check from version 0.3
// TODO: what shall we set for this version? (consider the basic
compatibility)
- VersionUtil.check(CoreVersion.VERSION, "0.13", "0.14",
CoreVersion.NAME);
+ VersionUtil.check(CoreVersion.VERSION, "1.0.0", "1.0.1",
CoreVersion.NAME);
Review Comment:
too strict
##########
hugegraph-core/src/main/java/org/apache/hugegraph/version/CoreVersion.java:
##########
@@ -41,6 +41,6 @@ public class CoreVersion {
public static void check() {
// Check version of hugegraph-common
// TODO: why shall we check it? Update it if need
- VersionUtil.check(CommonVersion.VERSION, "2.1.0", "2.2.0",
CommonVersion.NAME);
+ VersionUtil.check(CommonVersion.VERSION, "1.0.0", "1.0.1",
CommonVersion.NAME);
Review Comment:
maybe 1.0~1.2 first
##########
hugegraph-core/pom.xml:
##########
@@ -325,7 +325,7 @@
</addDefaultSpecificationEntries>
</manifest>
<manifestEntries>
-
<Implementation-Version>0.13.0.0</Implementation-Version>
+
<Implementation-Version>${project.version}</Implementation-Version>
Review Comment:
it's right here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
