[GitHub] [incubator-hugegraph] z7658329 commented on a diff in pull request #2033: fix outdated manifest version & use project.version instead

[GitBox]

z7658329 commented on code in PR #2033:
URL: 
https://github.com/apache/incubator-hugegraph/pull/2033#discussion_r1032085207


##########
hugegraph-api/src/main/java/org/apache/hugegraph/version/ApiVersion.java:
##########
@@ -122,11 +122,11 @@ public final class ApiVersion {
      * The second parameter of Version.of() is for IDE running without JAR
      * TODO: what shall we set for this version? (consider the basic 
compatibility)
      */
-    public static final Version VERSION = Version.of(ApiVersion.class, "0.69");
+    public static final Version VERSION = Version.of(ApiVersion.class, 
"1.0.0");
 
     public static void check() {
         // Check version of hugegraph-core. Firstly do check from version 0.3
         // TODO: what shall we set for this version? (consider the basic 
compatibility)
-        VersionUtil.check(CoreVersion.VERSION, "0.13", "0.14", 
CoreVersion.NAME);
+        VersionUtil.check(CoreVersion.VERSION, "1.0.0", "1.0.1", 
CoreVersion.NAME);

Review Comment:
   keep 1.0~1.2 first ? @imbajin 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org