imbajin commented on code in PR #204:
URL:
https://github.com/apache/incubator-hugegraph-computer/pull/204#discussion_r1032796796
##########
computer-algorithm/pom.xml:
##########
@@ -20,16 +20,16 @@
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
<parent>
<artifactId>hugegraph-computer</artifactId>
- <groupId>com.baidu.hugegraph</groupId>
- <version>0.1.4</version>
+ <groupId>org.apache.hugegraph</groupId>
+ <version>1.0.0</version>
Review Comment:
could add a constant `${revison} ` then use it (like
[client](https://github.com/apache/incubator-hugegraph-toolchain/blob/713eefb5c08f094c75214a0b5719ce6a03d079f2/hugegraph-client/pom.xml#L23)/loader
in toolchain) to avoid update a string of version, and use it also in
root-pom, so that we could just update **one version** in the whole project
so as other modules
_BTW, avoid using ${version} because it's a built-in param (and outdated)_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
