imbajin commented on code in PR #2038:
URL:
https://github.com/apache/incubator-hugegraph/pull/2038#discussion_r1034328458
##########
hugegraph-dist/pom.xml:
##########
@@ -178,22 +178,10 @@
<goal>run</goal>
</goals>
<configuration>
- <tasks>
- <echo file="${top.level.dir}/dist.sh">
- tar -zcvf \
- ${top.level.dir}/${final.name}.tar.gz \
- ${final.name} || exit 1
- rm -f ${top.level.dir}/dist.sh
- echo
- echo "HugeGraph dist tar.gz available at:
- ${top.level.dir}/${final.name}.tar.gz"
- echo
- </echo>
- <exec executable="${shell-executable}"
- dir="${top.level.dir}"
failonerror="true">
- <arg line="./dist.sh"/>
- </exec>
- </tasks>
+ <target>
+ <tar
+
destfile="${top.level.dir}/${final.name}.tar.gz"
basedir="${top.level.dir}/${final.name}" compression="gzip"/>
Review Comment:
use one line is fine, and do u test it in local env?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
