imbajin commented on code in PR #122:
URL:
https://github.com/apache/incubator-hugegraph-commons/pull/122#discussion_r1038990971
##########
hugegraph-dist/scripts/dependency/check_dependencies.sh:
##########
@@ -16,16 +16,16 @@
# limitations under the License.
#
-BASE_PATH=$(cd $(dirname $0); pwd)
+BASE_PATH=$(cd "$(dirname "$0")" || exit; pwd)
# check whether there are new third-party dependencies by diff command,
# diff generated 'current-dependencies.txt' file with 'known-dependencies.txt'
file.
-diff -w -B -U0 <(sort < ${BASE_PATH}/known-dependencies.txt) \
-<(sort < ${BASE_PATH}/current-dependencies.txt) > ${BASE_PATH}/result.txt
+diff -w -B -U0 <(sort <"${BASE_PATH}"/known-dependencies.txt) \
Review Comment:
it's better to not keep space after `<` or `>` in the shell script style
(avoid `< ()` and `file_descriptor > xx` error)
but keep the original style is also fine (revert it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
