z7658329 commented on code in PR #390:
URL:
https://github.com/apache/incubator-hugegraph-toolchain/pull/390#discussion_r1039276197
##########
hugegraph-loader/pom.xml:
##########
@@ -648,19 +648,12 @@
<goal>run</goal>
</goals>
<configuration>
- <tasks>
- <echo file="${project.basedir}/dist.sh">
- tar -zcvf \
- ${project.basedir}/${final.name}.tar.gz
${final.name} || exit 1
- rm -f ${project.basedir}/dist.sh
- echo -n "hugegraph-loader tar.gz available
at: "
- echo
"${project.basedir}/${final.name}.tar.gz"
- </echo>
- <exec executable="${shell-executable}"
- dir="${project.basedir}"
failonerror="true">
- <arg line="./dist.sh"/>
- </exec>
- </tasks>
+ <target>
+ <tar
destfile="${project.basedir}/${final.name}.tar.gz"
+ basedir="${project.basedir}"
+ includes="${final.name}/**"
Review Comment:
>
i have fix all tools binary rename in pr #387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
