[GitHub] [incubator-hugegraph] imbajin commented on a diff in pull request #2048: chore: prepare for apache v1.0.0 release

[GitBox]

imbajin commented on code in PR #2048:
URL: 
https://github.com/apache/incubator-hugegraph/pull/2048#discussion_r1043163604


##########
pom.xml:
##########
@@ -39,21 +39,55 @@
     <licenses>
         <license>
             <name>The Apache Software License, Version 2.0</name>
-            <url>http://www.apache.org/licenses/LICENSE-2.0.txt</url>
+            <url>httpS://www.apache.org/licenses/LICENSE-2.0.txt</url>
             <distribution>repo</distribution>
         </license>
     </licenses>
 
-    <prerequisites>
-        <maven>3.5.0</maven>
-    </prerequisites>
+    <developers>
+      <developer>
+        <id>Apache Hugegraph(incubating)</id>
+        <email>dev-subscr...@hugegraph.apache.org</email>
+        <url>https://hugegraph.apache.org/</url>
+      </developer>
+    </developers>
+
+    <mailingLists>
+      <mailingList>
+        <name>Development List</name>

Review Comment:
   keep the origin is also fine, the xml tag is `mailingList` already, and 
other apache repo has the similar name:
   
   <img width="538" alt="image" 
src="https://user-images.githubusercontent.com/17706099/206418991-e189e2ef-8a33-4751-9c2d-93268111ac8b.png";>
   
   <img width="471" alt="image" 
src="https://user-images.githubusercontent.com/17706099/206418084-bd9cd20d-ff1f-4a04-a43b-0c183fa89c56.png";>
   
   however, seems better to use `developer` instead of `development`? 😺 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org