imbajin commented on code in PR #392:
URL:
https://github.com/apache/incubator-hugegraph-toolchain/pull/392#discussion_r1043418332
##########
hugegraph-dist/pom.xml:
##########
@@ -35,9 +35,9 @@
cd $root_path
mkdir -p ${final.name}
- mv
$root_path/hugegraph-hubble/hugegraph-hubble
${final.name}/hugegraph-hubble-${project.version}
- mv
$root_path/hugegraph-loader/hugegraph-loader-${project.version}
${final.name}/hugegraph-loader-${project.version}
- mv
$root_path/hugegraph-tools/hugegraph-tools-${project.version}
${final.name}/hugegraph-tools-${project.version}
+ mv -v
$root_path/hugegraph-hubble/apache-hugegraph-hubble-incubating-${project.version}
${final.name}/
+ mv -v
$root_path/hugegraph-loader/apache-hugegraph-loader-incubating-${project.version}
${final.name}/
+ mv -v
$root_path/hugegraph-tools/apache-hugegraph-tools-incubating-${project.version}
${final.name}/
Review Comment:
> @z7658329 will the `${final.name}` be different in one pom file? seems a
little strange
>
> is the output right?
make a mistake, the 2nd param is the dest dir (treat as the source dir
before, which is wrong)
and shall we use `mv -v xx/*/*hugegraph-*xx/ destDir/` to replace current
command?
but current way is more accurate, use it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
