imbajin commented on code in PR #218:
URL:
https://github.com/apache/incubator-hugegraph-computer/pull/218#discussion_r1044286482
##########
computer-dist/scripts/apache-release.sh:
##########
@@ -21,8 +21,10 @@ GROUP="hugegraph"
REPO="${GROUP}-computer"
# release version (input by committer)
RELEASE_VERSION=$1
+USERNAME=$2
+PASSWORD=$3
# git release branch (check it carefully)
-GIT_BRANCH="release-${RELEASE_VERSION}"
+GIT_BRANCH="$(git branch --show-current)"
Review Comment:
seems a little dangerous when upload with a wrong branch? or check the
`branch-name` below?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
