javeme commented on code in PR #2061:
URL:
https://github.com/apache/incubator-hugegraph/pull/2061#discussion_r1059284764
##########
hugegraph-core/src/main/java/org/apache/hugegraph/structure/HugeEdge.java:
##########
@@ -364,6 +369,7 @@ public void vertices(HugeVertex owner, HugeVertex other) {
if (ownerLabel.equals(this.label.sourceLabel())) {
this.vertices(true, owner, other);
} else {
+ // TODO: why when compare the label but ignore the result?
Review Comment:
maybe missing assert
##########
hugegraph-core/src/main/java/org/apache/hugegraph/structure/HugeEdge.java:
##########
@@ -202,6 +204,11 @@ public <V> Property<V> property(String key, V value) {
E.checkArgument(this.label.properties().contains(propertyKey.id()),
"Invalid property '%s' for edge label '%s'",
key, this.label());
+ if (value == null) {
Review Comment:
also update `HugeVertex.property(String key, V value)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
