imbajin commented on code in PR #2095: URL: https://github.com/apache/incubator-hugegraph/pull/2095#discussion_r1098853204
########## hugegraph-core/src/main/java/org/apache/hugegraph/traversal/optimize/HugeScriptTraversal.java: ########## @@ -32,6 +32,7 @@ import org.apache.tinkerpop.gremlin.process.traversal.util.DefaultTraversal; /** + * TODO: lack LICENSE reference Review Comment: > look like "[apache/tinkerpop@`master`/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/ScriptTraversal.java](https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/ScriptTraversal.java?rgh-link-date=2023-01-20T12%3A37%3A02Z)" should i add APV2 to the annotation? we license and the origin license is same no need modify header but should refer in LICENSE & NOTICE, and remove the `TODO` if we fixed it ########## hugegraph-core/src/main/java/org/apache/hugegraph/traversal/optimize/HugeScriptTraversal.java: ########## @@ -32,6 +32,7 @@ import org.apache.tinkerpop.gremlin.process.traversal.util.DefaultTraversal; /** + * TODO: lack LICENSE reference Review Comment: > look like "[apache/tinkerpop@`master`/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/ScriptTraversal.java](https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/ScriptTraversal.java?rgh-link-date=2023-01-20T12%3A37%3A02Z)" should i add APV2 to the annotation? we license and the origin license is same no need to modify header but should refer in LICENSE & NOTICE, and remove the `TODO` if we fixed it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hugegraph.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
