[GitHub] [incubator-hugegraph] imbajin commented on a diff in pull request #2095: refact: mark TODO in the license problem code & use standard UTF-8

[via GitHub]

imbajin commented on code in PR #2095:
URL: 
https://github.com/apache/incubator-hugegraph/pull/2095#discussion_r1123097675


##########
hugegraph-core/src/main/java/org/apache/hugegraph/util/StringEncoding.java:
##########
@@ -137,18 +129,23 @@ public static byte[] compress(String value) {
     }
 
     public static byte[] compress(String value, float bufferRatio) {
-        BytesBuffer buf = LZ4Util.compress(encode(value), BLOCK_SIZE,
-                                           bufferRatio);
-        return buf.bytes();
+        try (BytesBuffer buf = LZ4Util.compress(encode(value), BLOCK_SIZE, 
bufferRatio)) {
+            return buf.bytes();
+        } catch (IOException e) {

Review Comment:
   > yes just remove the catch, since the LZ4Util.compress already transfer 
IOException to BackendException
   
   so shall we close the `ByteBuffer` when it used up? if we remove catch with 
`try(xx)`, we need throws the exception?
   
   It means we just ignore the `ByteBuffer` close?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org