imbajin commented on code in PR #2130:
URL:
https://github.com/apache/incubator-hugegraph/pull/2130#discussion_r1127701546
##########
hugegraph-core/src/main/java/org/apache/hugegraph/masterelection/StandardRoleElectionStateMachine.java:
##########
@@ -49,7 +53,11 @@ public void apply(StateMachineCallback stateMachineCallback)
{
while (!this.shutdown) {
E.checkArgumentNotNull(this.state, "State don't be null");
try {
+ RoleState pre = this.state;
this.state = state.transform(context);
Review Comment:
Note: `state.transform` is not an atomic operation, it means the `state`
could be unstable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
