zhenyuT commented on code in PR #133:
URL:
https://github.com/apache/incubator-hugegraph-commons/pull/133#discussion_r1309524484
##########
hugegraph-common/src/test/java/org/apache/hugegraph/unit/rest/RestClientTest.java:
##########
@@ -192,51 +206,54 @@ public void testPostWithMaxTotalAndPerRoute() {
Assert.assertEquals(200, restResult.status());
}
- @Test
- public void testCleanExecutor() throws Exception {
- // Modify IDLE_TIME 100ms to speed test
- int newIdleTime = 100;
- int newCheckPeriod = newIdleTime + 20;
-
- RestClient client = new RestClientImpl("/test", 1000, newIdleTime,
Review Comment:
okhttp没有显式清理连接的线程，因此也不需要进行测试
##########
hugegraph-common/src/test/java/org/apache/hugegraph/unit/rest/RestClientTest.java:
##########
@@ -192,51 +206,54 @@ public void testPostWithMaxTotalAndPerRoute() {
Assert.assertEquals(200, restResult.status());
}
- @Test
- public void testCleanExecutor() throws Exception {
- // Modify IDLE_TIME 100ms to speed test
- int newIdleTime = 100;
- int newCheckPeriod = newIdleTime + 20;
-
- RestClient client = new RestClientImpl("/test", 1000, newIdleTime,
Review Comment:
okhttp没有显式清理连接的线程，因此也不需要进行测试
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
