byteayan opened a new issue, #3245:
URL: https://github.com/apache/hugegraph/issues/3245

   ## Background
   
   Follow-up to #3086 / #3244. `RedirectFilter` forwards requests for endpoints 
annotated with `@RedirectFilter.RedirectMasterRole` to the elected master node. 
It only acts when `GlobalMasterInfo.supportElection()` is true:
   
   
https://github.com/apache/hugegraph/blob/2f827d6e8c9c62ae858f2fc122b3a192d015e2f4/hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/api/filter/RedirectFilter.java#L85-L88
   
   The only code that set it to true was `GraphManager.initRoleStateMachine()`, 
which nothing has called since #3082. #3244 deletes that method together with 
the rest of the role election code, so no code path can enable the flag. The 
filter is still registered on the 21 schema, job, task and raft endpoint 
methods that carry the annotation and returns early on every request.
   
   `GraphTransaction.queryServerInfos(...)` is in the same state. It read the 
`~server` vertices that `HugeServerInfo` used to write, and it has no callers.
   
   ## Scope
   
   - Delete `RedirectFilter`, `RedirectFilterDynamicFeature`, the 
`RedirectMasterRole` annotation on the endpoints that use it, and the 
registration in `ApplicationConfig`. Drop 
`AccessLogFilterTest.testRedirectRunsAfterBodyCapture`.
   - Remove `supportElection`, `masterInfo(...)`, `resetMasterInfo()`, 
`NodeInfo` and the stale "delete the startup of master-worker" TODO from 
`GlobalMasterInfo`. Keep the node id and node role parts, which 
`ServerInfoManager` and `GraphManager` still use.
   - Delete both `GraphTransaction.queryServerInfos(...)` overloads.
   
   ## Constraints
   
   - No REST behavior changes, since the redirect never runs today. The 
`x-hg-redirect` header would simply stop being recognised.
   - Keep `HugeType.SERVER` and the `~server` / `~role_data` label mapping in 
`HugeVertex`, because graphs written by older versions may still hold those 
vertices.
   - Depends on #3244 being merged first.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to