bitflicker64 opened a new issue, #3284:
URL: https://github.com/apache/hugegraph/issues/3284

   ### Bug Type (问题类型)
   
   rest-api (结果不合预期)
   
   ### Before submit
   
   - [x] I have confirmed and searched that there are no similar problems in 
the historical issue and documents
   
   ### Environment (环境信息)
   
   - Server Version: 1.7.0 (`hugegraph/server:latest`, image `0c58df2cae57`; 
`GET /versions` reports core 1.7.0). The code below is unchanged on `master` at 
`d9abcd4`
   - Backend: RocksDB, 1 node, `usePD=false`, authentication on (`PASSWORD` set)
   - OS: Docker on Linux
   - Data Size: empty graph
   
   ### Expected & Actual behavior (期望与实际表现)
   
   Expected: any password the user API accepts can be used for HTTP Basic login.
   
   Actual: the API accepts a non-ASCII password and a password containing `:`, 
but Basic login with either one fails. Measured 2026-10-07: set the admin 
password with `PUT /graphspaces/DEFAULT/auth/users/-27:admin`, then call `GET 
/graphs` with `curl -u admin:<new password>`.
   
   | New admin password | `PUT` | Basic login with the new password | Basic 
login with the old password |
   |---|---|---|---|
   | `newpass1234` (control) | 200 | 200 | 401 |
   | `ädminpass1` | 200 | 401 `Authentication failed` | 401 |
   | `new:pass1234` | 200 | 400 `Invalid syntax for username and password` | 
not tried |
   
   The non-ASCII row leaves the admin account with no working Basic login.
   
   Cause, in 
[`AuthenticationFilter.java:192-195`](https://github.com/apache/hugegraph/blob/d9abcd4317fb36128e7e4d209139ec7f3a28cdfc/hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/api/filter/AuthenticationFilter.java#L192-L195):
   
   ```java
   auth = new String(DatatypeConverter.parseBase64Binary(auth), 
Charsets.ASCII_CHARSET);
   String[] values = auth.split(":");
   if (values.length != 2) {
       throw new BadRequestException("Invalid syntax for username and 
password");
   ```
   
   1. Decoding as US-ASCII turns every non-ASCII byte into U+FFFD, so the 
password checked is never the one that was stored.
   2. `split(":")` cuts the password at every colon. RFC 7617 forbids a colon 
only in the user-id, so the credential should be split on the first colon.
   
   Proposed fix: decode as UTF-8 (RFC 7617 section 2.1) and split at 
`auth.indexOf(':')`. A regression test in the auth API tests can cover both 
cases.
   
   The Helm chart works around this by refusing such admin passwords in 
[`values.schema.json:824`](https://github.com/apache/hugegraph/blob/d9abcd4317fb36128e7e4d209139ec7f3a28cdfc/helm/hugegraph/values.schema.json#L824)
 and in its Server wrapper. The TODO at 
[`AuthenticationFilter.java:187`](https://github.com/apache/hugegraph/blob/d9abcd4317fb36128e7e4d209139ec7f3a28cdfc/hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/api/filter/AuthenticationFilter.java#L187)
 (from #3260) points here, and that guard can go once this is fixed.
   
   Proposed for 1.8.0 (#3242): the fix is two lines, and today an admin 
password change through the API can lock the admin out of Basic login.
   
   <details>
   <summary>Reproduction</summary>
   
   On a Server with authentication enabled and admin password `adminpass123`:
   
   ```bash
   S=http://127.0.0.1:8080/graphspaces/DEFAULT/auth/users
   curl -s -u admin:adminpass123 -X PUT -H 'Content-Type: application/json' \
     --data-binary '{"user_password":"new:pass1234"}' "$S/-27:admin"
   curl -s -u 'admin:new:pass1234' http://127.0.0.1:8080/graphs   # 400
   ```
   
   In the run above, the `docker run` entrypoint (`HG_SERVER_BACKEND=rocksdb`, 
`HG_SERVER_USE_PD=false`) kept waiting for a Store, so the Server was started 
inside the container with `bin/init-store.sh` and `bin/start-hugegraph.sh`.
   
   </details>
   
   ### Vertex/Edge example (问题点 / 边数据举例)
   
   N/A
   
   ### Schema [VertexLabel, EdgeLabel, IndexLabel] (元数据结构)
   
   N/A
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to