I believe datastax-labs/hunter is being moved into apache/hunter by ASF-infra, according to: https://issues.apache.org/jira/browse/HUNTER-1 <https://issues.apache.org/jira/browse/HUNTER-1> Tracked in https://issues.apache.org/jira/browse/INFRA-26336 <https://issues.apache.org/jira/browse/INFRA-26336> (though I can’t view this issue).
If not, or maybe I've misunderstood, I’m happy to move the commit history into apache/hunter. Sean > On Dec 9, 2024, at 6:14 AM, Henrik Ingo <hen...@nyrkio.com> wrote: > > I think we would like https://github.com/datastax-labs/hunter to be > ceremoniously pushed as the main branch. Of course, my 6 commits are now > rebased on top of it too, but they are more or less new to the rest of the > community, so submitting them as separate PRs, or in any case as one single > separate PR, would be more proper. And it's a good opportunity to practice > reviews. We honestly don't expect hunter to be that busy in terms of > commits. Those 6 represent half a year of progress. > > That said, there is an additional layer of functionality we have in Nyrkiö > code that could be now (finally!) refactored down to hunter. But > refactoring is work too, who knows when we get a moment to actually do it. > > henrik > > On Mon, Dec 9, 2024 at 8:46 AM Lari Hotari <lhot...@apache.org> wrote: > >> I could help push >> https://github.com/nyrkio/hunter/tree/to-asf-upstream2 as the main >> branch in https://github.com/apache/hunter repository if that's what >> we'd want to have as the starting point. >> >> There's an "Initial Clean Up" step described here: >> https://incubator.apache.org/guides/transitioning_asf.html#initial_clean_up >> . >> The Incubator guide states "We recommend that you start the initial >> cleanup before you commit the code. You MUST complete it before >> creating any releases." >> >> Are we planning to complete the "initial clean up" outside of >> apache/hunter or would we just push what we have and then continue >> with the cleanup in apache/hunter? Both ways are acceptable. >> >> -Lari >> >> On Sun, 8 Dec 2024 at 22:30, Henrik Ingo <hen...@nyrkio.com> wrote: >>> >>> Hi all >>> >>> I didn't yet receive powers to push the entire hunter repo into >>> https://github.com/apache/hunter >>> >>> ...and since there isn't any code or branches there, I also cannot >> create a >>> pull request just yet. But... I did spend this Sunday afternoon >> preparing a >>> branch that is rebased on top of what I expect to become the canonical >>> upstream: >>> >>> https://github.com/nyrkio/hunter/tree/to-asf-upstream2 >>> >>> Apparently our fork is 6 commits ahead. I will submit separate PRs once >>> there is a repo in place to submit PRs against. But you can already >> take a >>> sneak peek from above. >>> >>> The two most interesting ones should be: >>> - Add to_json() and from_json() serialization methods' >>> - Incremental Hunter: Since Datastax introduced an approach where we >> only >>> consider the w(indown length) closest points, it turns out that the next >>> logical step is an optimization: since the common case is that new test >>> results are appended to the end, we can limit the recompute to the 1-2 >>> last windows at the tail end. Everything before that point is guaranteed >> to >>> not have changed, because the newly added test result is not inside the >>> window that is considered as input for the algorithm. >>> >>> Other changes are fixes or an additional test/benchmark. Some are quite >>> interesting stlil. Especially I can tell with confidence that Piotr never >>> thought of using a p-value of 0.1 or higher :-) (You can look at the >> patch >>> yourself to find out.) >>> >>> henrik >>